setup: fix deployment of template cpp files#97
Merged
dboyliao merged 1 commit intouTensor:developfrom Jan 9, 2020
Merged
Conversation
dboyliao
approved these changes
Jan 9, 2020
Member
dboyliao
left a comment
dboyliao
left a comment
There was a problem hiding this comment.
Thanks a lot @aabadie.
I changed the module hierarchy and forgot to change the path.
Thank you for fixing this.
It looks like our CI gets stuck now.
I run your PR locally on my machine and it works fine so I'll merge your PR later.
BTW, I'll send you a slack invitation link to your email.
Feel free to join us on slack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the deployment of template cpp files in the package generated with pip.
When installing utensor_cgen using pip (like it's documented in the README), the template files are not present and the script crashes when generating the model cpp files.
Also you should not use the
-eoption in the CI setup command:utensor_cgen/.circleci/config.yml
Line 9 in 6b8ccf3
Just use
pip3 install .with CI to perform a standard installation like any regular user would do and keep the-eoption for your local development env.