Fix panic in PDF export when multiple captions appear inside a figure#7177
Merged
laurmaedje merged 2 commits intomainfrom Oct 17, 2025
Merged
Fix panic in PDF export when multiple captions appear inside a figure#7177laurmaedje merged 2 commits intomainfrom
laurmaedje merged 2 commits intomainfrom
Conversation
laurmaedje
pushed a commit
that referenced
this pull request
Oct 17, 2025
RaikiSakaguchi
pushed a commit
to doss-eeic/2025-06-typst
that referenced
this pull request
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a panic in krilla when
captionis overwritten and thus missing from the generated tag tree.It also adds a check for tables and lists when they contain more than one caption.
There are other cases with multiple captions where the structure is not really ideal, but validating those is a bit out of scope. And should probably be done when implementing complete tag structure validation in krilla.