Merged
Conversation
EpicEricEE
reviewed
Oct 3, 2025
Member
|
The translations are used in tooltips for |
Collaborator
Author
|
But the English translation for |
8d26ef2 to
0fdee02
Compare
Member
|
The code works as follows: // Contents of the tooltip for the link
let contact = url.strip_contact_scheme().map(|(scheme, stripped)| {
// Will result in `<phone number LocalName> +123456789` in the tooltip for
// something like `#link("tel:+123456789")`
eco_format!("{} {stripped}", scheme.local_name_in(styles))
});This is the only use for the |
This was referenced Oct 6, 2025
Collaborator
Author
|
Then this can be merged as is |
Member
|
Thanks! |
Contributor
|
hmm, "courriel" is definitely used almost everywhere in Québec. For example,
It is a government website. We probably need a separate |
Collaborator
Author
Yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This adds some French translations.
The actual French word for "email" would be "courriel" or "mél" but I don't think anyone uses those words in the real world.
Also, depending on where those translations are used, it might be better to use "Adresse mail" ("E-mail address") and "Numéro de téléphone" ("Phone number").