Fix calc.inf, -calc.inf, and calc.nan reprs and displays#4724
Merged
laurmaedje merged 4 commits intotypst:mainfrom Aug 11, 2024
Merged
Fix calc.inf, -calc.inf, and calc.nan reprs and displays#4724laurmaedje merged 4 commits intotypst:mainfrom
calc.inf, -calc.inf, and calc.nan reprs and displays#4724laurmaedje merged 4 commits intotypst:mainfrom
Conversation
Member
|
Thanks!
That makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2955.
I decided to use
calc.infandcalc.naninstead offloat("inf")andfloat("nan")because the former feel like constants, while the latter feel like more arbitrary ways of getting the values. Ideally, I thinkfloat.infandfloat.nanwould be better (see side note below).calc.inf"calc.inf"-calc.inf"-calc.inf"calc.nan"calc.nan"calc.inf * 1pt"calc.inf * 1pt"-calc.inf * 1pt"-calc.inf * 1pt"I also added some unrelated float-related tests in the last commit.
As a side note, I'm wondering whether we should move
calc.infandcalc.nantofloat.infandfloat.nanas they seem more related to the IEEE-754 format than to calculations.