Conversation
3e9637d to
5243cff
Compare
aedd313 to
fc4b688
Compare
|
Would it not make more sense for the numbering to cover the entire alphabet rather than the first 10 characters? Base 26 (or however many characters greek has) rather than base 10 |
Hi @Jamesxx I think the main issue is definition on what is the Greek numeral system. I believe the system you just described is called lower-greek which represent 11 as λ (the 11-th char of the alphabet), while the greek numbering system is a decimal-like system (though with a different set of chars), 11 is represented by "ιαʹ" (where "ι" is 10 and "α" is 1). That being said, it seems to me that both should be implemented if permitted. |
laurmaedje
left a comment
There was a problem hiding this comment.
Here are a few comments, but not really relevant ones, since I can't judge the correctness of the Greek numbering itself. And then there is of course also still the question of the letter etc.
I'm not sure how best to proceed here.
8e1ef0f to
14cdcde
Compare
|
I merged with main and tidied up the tests. While doing that I noticed that the number 2000000001 comes out differently with your code than with the online converter:
|
2584741 to
4013216
Compare
|
Regarding the letter. It think we should use |
Sorry, I did not realize it is so long ago and almost forgot this PR. I have just updated the PR with a fix and added more test cases.
the current way should be this case, using the
I like this idea as well! I am interested it supporting it but do not know how to start with it, do you have some hint/high level ideas on how to do it? that would be great. |
Thanks!
Yep.
Responded here: #1177 (comment) |
|
Thank you! |
Regarding Issue #3882,
I mainly took references from Greek Number Converter and Greek Number
I am for now using the lowercase and upper case Alpha as the symbol.
Some test cases (unicode level) are added in
numbering.rsPng rendered
