You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @9il,
thank you very much for your rework!
I have a done a small comparison between your branch and ours. Your rework gives a enormous speed up for all variations.
Especially the slice version only takes have the time
Thanks!
Hope I will add sweep_ndslice next week. sweep_ndslicewill have a mir.ndslice idiomatic implementation like the new projection, also weighted projection can be additionally simplified.
And maybe a multithreaded version will be added too.
Would you mind to update the README and charts when all changes ready?
The default sweep algorithm changes to ndslice, which may not be the fastest version. It is smaller, either to write and supports higher dimensions.
The field version doesn't use Mir except for API and looks more like C/C++ code. It isn't bad, but I am afraid that it may scare away potential users if we make it athe default sweep algorithm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog:
sweep_sliceto access memory only once like the Python code. I didn't make a benchmark, but I expect it will be a few times faster now.fastmathto the kernel-like API andpragma(inline, false)for some API. The last one is required to make the first one work well./with*where possible (it is fine for this kind of numeric code).mir.*alternatives if possible.