Fix CheckVisibilityPlugin to check interfaces

vudaltsov · vudaltsov · commit 9d7b03d7d6cb · 2024-08-08T02:58:33.000+03:00
diff --git a/tests/Reflection/Internal/NativeReflector/DefinedConstantReflectorTest.php b/tests/Reflection/Internal/NativeReflector/DefinedConstantReflectorTest.php
@@ -45,7 +45,7 @@ public static function definedConstantsWithoutNAN(): \Generator
 
                 yield $name => [Id::constant($name), $extension, $value];
 
-                return ;
+                return;
             }
         }
     }
diff --git a/tools/psalm/src/CheckVisibilityPlugin.php b/tools/psalm/src/CheckVisibilityPlugin.php
@@ -8,33 +8,28 @@
 use Psalm\CodeLocation;
 use Psalm\Issue\PluginIssue;
 use Psalm\IssueBuffer;
-use Psalm\Plugin\EventHandler\AfterClassLikeAnalysisInterface;
+use Psalm\Plugin\EventHandler\AfterClassLikeVisitInterface;
 use Psalm\Plugin\EventHandler\AfterFunctionLikeAnalysisInterface;
-use Psalm\Plugin\EventHandler\Event\AfterClassLikeAnalysisEvent;
+use Psalm\Plugin\EventHandler\Event\AfterClassLikeVisitEvent;
 use Psalm\Plugin\EventHandler\Event\AfterFunctionLikeAnalysisEvent;
 use Psalm\Plugin\PluginEntryPointInterface;
 use Psalm\Plugin\RegistrationInterface;
 
 /**
  * @psalm-suppress UnusedClass
  */
-final class CheckVisibilityPlugin implements PluginEntryPointInterface, AfterClassLikeAnalysisInterface
+final class CheckVisibilityPlugin implements PluginEntryPointInterface, AfterClassLikeVisitInterface
 {
-    public static function afterStatementAnalysis(AfterClassLikeAnalysisEvent $event): ?bool
+    public static function afterClassLikeVisit(AfterClassLikeVisitEvent $event): void
     {
-        $class = $event->getClasslikeStorage();
+        $class = $event->getStorage();
 
         if ($event->getStmt()->name !== null && !$class->internal && !$class->public_api) {
-            IssueBuffer::accepts(
-                new UnspecifiedVisibility(
-                    'Class ' . $class->name,
-                    $class->location ?? new CodeLocation($event->getStatementsSource(), $event->getStmt()),
-                ),
-                $event->getStatementsSource()->getSuppressedIssues(),
+            $class->docblock_issues[] = new UnspecifiedVisibility(
+                'Class ' . $class->name,
+                $class->location ?? new CodeLocation($event->getStatementsSource(), $event->getStmt()),
             );
         }
-
-        return null;
     }
 
     public function __invoke(RegistrationInterface $registration, ?\SimpleXMLElement $config = null): void

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ public static function definedConstantsWithoutNAN(): \Generator`
`45`	`45`
`46`	`46`	`yield $name => [Id::constant($name), $extension, $value];`
`47`	`47`
`48`		`- return ;`
	`48`	`+ return;`
`49`	`49`	`}`
`50`	`50`	`}`
`51`	`51`	`}`