Improve nullability annotations for PreparedStatement, CallableStatement, ResultSet#64
Merged
mernst merged 1 commit intotypetools:masterfrom Jul 26, 2020
Merged
Conversation
Member
|
Thanks for these annotations! My apologies that this pull request languished. I wasn't watching the repository, so I didn't get notified. |
aosen-xiong
pushed a commit
to aosen-xiong/jdkopprop
that referenced
this pull request
Mar 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most
get...are allowed to returnnull(e.g.getString), so I added@Nullablefor other getters likegetRowid().There are two less trivial changes:
a)
I'm not sure if it should be written as
public <@Nullable T> T ....b)
(...Calendar cal). It is not clear if the spec allowsnullcalendar, however, AFAIK the implementations allow nulls, and there's an obscure Javadoc which suggests thatcalendar can be missing.The only way I can imagine a "missing" calendar is a
nullreference.