Pin requests to <2.30.0 to fix test failures#95
Merged
JelleZijlstra merged 1 commit intotypeshed-internal:mainfrom May 3, 2023
Merged
Pin requests to <2.30.0 to fix test failures#95JelleZijlstra merged 1 commit intotypeshed-internal:mainfrom
JelleZijlstra merged 1 commit intotypeshed-internal:mainfrom
Conversation
`requests v2.30.0` has just been released: https://github.com/psf/requests/releases/tag/v2.30.0 It appears to be causing the stub-uploader tests to fail on the typeshed `main` branch: - https://github.com/python/typeshed/actions/runs/4873926053/jobs/8694191409 - https://github.com/python/typeshed/actions/runs/4873908728/jobs/8694149563 I haven't looked into what's causing the failures at all, but here's a stopgap PR to pin `requests` and stop the tests from failing
AlexWaygood
changed the title
Contributor
Author
|
Confirmed that typeshed's |
Contributor
|
Wow. Looks like they had to yank requests 2.30 psf/requests#6439 |
Contributor
Author
|
Ouch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requests v2.30.0has just been released: https://github.com/psf/requests/releases/tag/v2.30.0It appears to be causing the stub-uploader tests to fail on the typeshed
mainbranch:I haven't looked into what's causing the failures at all, but here's a stopgap PR to pin
requestsand stop the tests from failing