URL encode user-inputted Ids, migrate to Github actions#63
Merged
kishorenc merged 13 commits intotypesense:masterfrom Sep 7, 2024
Merged
URL encode user-inputted Ids, migrate to Github actions#63kishorenc merged 13 commits intotypesense:masterfrom
kishorenc merged 13 commits intotypesense:masterfrom
Conversation
Also allow special characters to be used in Ids
- breaking change: documents index actions is now an enum instead of string
…ask `sourcesJar` `Task ':sourcesJar' uses this output of task ':generateSwaggerCodeTypesense' without declaring an explicit or implicit dependency`
kishorenc
approved these changes
Sep 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
URL encode user-inputted Ids to prevent injection & allow usage of special characters.
Features
URLEncodinginsidetypesense/api/utils.gradle buildtestUpsertWithURLEncodedNameFixes
Build errors:
openapi.ymlfile because parent directories do not exist.Excluded the script to download
books.jsonlfrom github actions config file since it's unused.PR Checklist