Repository navigation
Incorrect TS7022 error displayed by Language Server in VSCode #766
Description
- VS Code Version: 1.83.0
- OS Version: MacOS Monterey 12.4 (but also shown in vscode on other MacOS versions)
Steps to Reproduce:
- Clone https://github.com/cleric-sh/repro/tree/phantom-ts7022-error-in-vscode
- Ensure switched to branch
phantom-ts7022-error-in-vscode npm inpm compile--> observe no compiler errors- Open index.ts
- Make a change to the file (e.g. add a space) to trigger LSP to re-analyse the file.
- Restart the TS Language Server and error disappears. Make a change, and error re-appears.
- Error should appear on
valueon line 26.
The error appears with all extensions disabled.
I've noted that the error is:
- Only shown when func param 'arg' type is declared. Removing the declaration resolves the error.
- Only shown in vscode. tsc compiles without errors.
- Only shown on second pass, after a change has been made to the file. Initial type check on load shows no errors.
- Only shown when noImplicitAny: true
Also, in a more complex file, declaring this function after doAnotherThing prevents the error being displayed.
All these points combined lead me to believe this is an error either in VS Code or the Typescript Language Server.
I've also created an issue in the VSCode GitHub repo: microsoft/vscode#195075
Activity
martaver commentedon Oct 7, 2023
I added
tsserver.logto the repro, which covers starting TS Language Server and making a change to the file.martaver commentedon Oct 7, 2023
Possibly related to issue: microsoft/vscode#177595
rchl commentedon Oct 20, 2023
Based on the linked issue it seems like the issue was fixed in typescript.
martaver commentedon Oct 23, 2023
Based on the repro I provided, in
vscode insiderswithtypescript@beta, the error is still present. This issue should still be open.rchl commentedon Oct 23, 2023
It's not likely that this issue is in this server. I would suggest reporting it in the typescript repo since it reproduces with VSCode also which doesn't use this server.
martaver commentedon Oct 23, 2023
rchl commentedon Oct 23, 2023
I can reproduce the issue but this server is just a thin LSP layer on top of the Typescript tsserver API.
I can address issues that are specific to this LSP layer maintained here but if the issue appears to be deep in typescript's core then I'm not willing to spend hours or days of my free time debugging the issue.
Since it reproduces in VSCode, creating a bug report in Typescript repo should get the attention of the right people. It looks like an issue that is specific to the tsserver API that Typescript exposes and that's why it reproduces both in VSCode and with this server which is based on VSCode's implementation.