feat(typescript-estree): forbid .body, .async, .generator on declare function
#9225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the PR, @Josh-Cena! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Josh-Cena
force-pushed
the
function-decl-ast-invariant
branch
from
4910e5c to
2303eeb
Compare
bradzacher
requested changes
Jun 4, 2024
Comment on lines
29
to
31
| export interface TSDeclareFunctionNoDeclare extends TSDeclareFunctionBase { | ||
| declare: false; | ||
| } |
Member
There was a problem hiding this comment.
function* foo(): Generator<never, void, unknown>;
// ^ TS1222: An overload signature cannot be declared as a generator.
function* foo(): Generator<never, void, unknown> { }Looks like we can exclude and crash on this case as well.
bradzacher
added
the
awaiting response
github-actions
bot
removed
the
awaiting response
Josh-Cena
force-pushed
the
function-decl-ast-invariant
branch
from
554253f to
bee58c7
Compare
bradzacher
changed the title
declare function.body, .async, .generator on declare function
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
TSDeclareFunctionhas no body,declare functioncannot haveasyncor*#9219Overview