-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
docs: add homepage #8742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add homepage #8742
Conversation
Thanks for the PR, @moskalakamil! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ... don't think that this will change the actual package.json
s that get published with packages? @typescript-eslint/eslint-plugin
, for example, comes from packages/eslint-plugin/package.json
. I believe you'll need to make this change in all those nested package.json
s instead.
Someone please yell at me if there's actually Nx magic under the hood I don't know of.
@JoshuaKGoldberg done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
I don't have a personal preference of which ones should point to the root website vs. a /packages/*
. If anybody else does then I suppose they can request changes. 😄
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8742 +/- ##
==========================================
- Coverage 88.01% 88.01% -0.01%
==========================================
Files 405 405
Lines 14076 14074 -2
Branches 4121 4120 -1
==========================================
- Hits 12389 12387 -2
Misses 1382 1382
Partials 305 305
Flags with carried forward coverage won't be shown. Click here to find out more. |
ecb6b55
into
typescript-eslint:main
Overview
Added homepage to
package.json
.After the merge, the homepage on npmjs.org will be replaced with the official documentation.