feat(eslint-plugin): deprecate no-throw-literal and add a renamed only-throw-error #8701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
yeonjuan
reviewed
Mar 23, 2024
Co-authored-by: YeonJuan <[email protected]>
3 tasks
auvred
requested changes
Mar 25, 2024
Member
auvred
left a comment
auvred
left a comment
There was a problem hiding this comment.
Looks great overall! But there is small docs issue
auvred
added
the
awaiting response
Co-authored-by: auvred <[email protected]>
peanutenthusiast
pushed a commit
to peanutenthusiast/typescript-eslint
that referenced
this pull request
Mar 27, 2024
…y-throw-error (typescript-eslint#8701) * feat(eslint-plugin): deprecate no-throw-literal and add a renamed only-throw-error * Update packages/eslint-plugin/docs/rules/no-throw-literal.mdx Co-authored-by: YeonJuan <[email protected]> * Updated options snapshot * Update packages/eslint-plugin/docs/rules/no-throw-literal.mdx Co-authored-by: auvred <[email protected]> --------- Co-authored-by: YeonJuan <[email protected]> Co-authored-by: auvred <[email protected]>
yeonjuan
added a commit
to yeonjuan/typescript-eslint
that referenced
this pull request
Mar 31, 2024
…y-throw-error (typescript-eslint#8701) * feat(eslint-plugin): deprecate no-throw-literal and add a renamed only-throw-error * Update packages/eslint-plugin/docs/rules/no-throw-literal.mdx Co-authored-by: YeonJuan <[email protected]> * Updated options snapshot * Update packages/eslint-plugin/docs/rules/no-throw-literal.mdx Co-authored-by: auvred <[email protected]> --------- Co-authored-by: YeonJuan <[email protected]> Co-authored-by: auvred <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Overview
Effectively renames
no-throw-literaltoonly-throw-error. This avoids being a breaking change per #6109's suggestion by keeping the rule under the old name as well.