Skip to content

fix: correct engines.node constraints in package.json #8671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2024
Merged

fix: correct engines.node constraints in package.json #8671

merged 1 commit into from
Mar 16, 2024

Conversation

MichaelDeBoey
Copy link
Contributor

These seem to be forgotten in #8377

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @MichaelDeBoey!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Mar 14, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 27ac5c4
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65f2f17e83917c0008f567f0
😎 Deploy Preview https://deploy-preview-8671--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (🟢 up 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Mar 14, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 27ac5c4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 from NxCloud.

@codecov Codecov
Copy link

codecov bot commented Mar 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.01%. Comparing base (609a000) to head (27ac5c4).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8671      +/-   ##
==========================================
+ Coverage   87.23%   88.01%   +0.78%     
==========================================
  Files         251      401     +150     
  Lines       12319    13919    +1600     
  Branches     3884     4090     +206     
==========================================
+ Hits        10746    12251    +1505     
- Misses       1303     1368      +65     
- Partials      270      300      +30
Flag Coverage Δ
unittest 88.01% <ø> (+0.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 150 files with indirect coverage changes

@bradzacher bradzacher added the bug Something isn't working label Mar 16, 2024
bradzacher
bradzacher approved these changes Mar 16, 2024
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what a silly mistake I made!
Thanks for catching this

Technically this is a breaking change - but given this breaking change was supposed to land with v7 I'm okay with landing it now.
If I wasn't lazy I'd backport it as a patch to 7.0, 7.1, and 7.2 to make sure it's applied for all released minors... but I'm lazy so just the latest will do.

@bradzacher bradzacher changed the title fix: update engines.node field in package.json fix: correct engines.node constraints in package.json Mar 16, 2024
@bradzacher bradzacher merged commit 883f220 into typescript-eslint:main Mar 16, 2024
59 of 60 checks passed
@MichaelDeBoey MichaelDeBoey deleted the patch-1 branch March 18, 2024 15:49
@kwonoj kwonoj mentioned this pull request Mar 18, 2024
Merged
@RobinTail RobinTail mentioned this pull request Mar 18, 2024
Merged
styfle pushed a commit to vercel/next.js that referenced this pull request Mar 18, 2024
@kwonoj
build(package): pin typescript-eslint/parser for supported node.js (#…
2cd58bb 
…63424)

### What

typescript-eslint/typescript-eslint#8671
introduces a change to enforce node.js >= 18.18.0. This is technically
breaking changes, and affects us as we support 18.17.0 still
(https://github.com/vercel/next.js/blob/canary/package.json#L254).

As a workaround, pin dep version to avoid 7.3.0 - later when we lift our
engines, can remove those.

Closes PACK-2763
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelDeBoey @bradzacher