Skip to content

feat: bump ESLint, NodeJS, and TS minimum version requirements #8377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Feb 6, 2024
Merged

feat: bump ESLint, NodeJS, and TS minimum version requirements #8377

merged 11 commits into from
Feb 6, 2024

Conversation

bradzacher
Copy link
Member

@bradzacher bradzacher commented Feb 5, 2024 •
edited
Loading

BREAKING CHANGE:
Bumps the minimum dependency requirements

Overview

Fixes #8346

Breaking changes:

  • Bump the minimum NodeJS version to v18.18.0 - which aligns with ESLint v9's minimum.
  • Drop support for NodeJS 19 (same as ESLint v9)
  • Bump the minimum TypeScript version to v4.7.5
  • Bump the minimum ESLint version to v8.56.0
  • Remove backwards-compatability helpers from @typescript-eslint/utils/eslint-utils (getAncestors, getCwd, getDeclaredVariables, getFilename, getScope, getSourceCode)

Other changes:

  • Update ESLint types to match the new minimum version.
  • Update the playground so it doesn't allow users to select an unsupported TS version.
  • Update the docs so that dependency versions are pulled in automatically.

@bradzacher
feat: bump ESLint, NodeJS, and TS minimum version requirements
e5db5a3 
BREAKING CHANGE:
Bumps the minimum requirements
@bradzacher bradzacher added breaking change This change will require a new major version to be released dependencies Issue about dependencies of the package labels Feb 5, 2024
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Feb 5, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 4776a10
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65c196fab89e4b00095804bf
😎 Deploy Preview https://deploy-preview-8377--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (🟢 up 10 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 5, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4776a10. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 33 targets

Sent with 💌 from NxCloud.

@codecov Codecov
Copy link

codecov bot commented Feb 5, 2024 •
edited
Loading

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (289ee88) 87.80% compared to head (4776a10) 87.84%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8377      +/-   ##
==========================================
+ Coverage   87.80%   87.84%   +0.03%     
==========================================
  Files         398      396       -2     
  Lines       14052    13809     -243     
  Branches     4090     4064      -26     
==========================================
- Hits        12338    12130     -208     
+ Misses       1403     1382      -21     
+ Partials      311      297      -14
Flag Coverage Δ
unittest 87.84% <98.09%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...lugin-internal/src/rules/plugin-test-formatting.ts 79.19% <100.00%> (-0.24%) ⬇️
packages/eslint-plugin-tslint/src/rules/config.ts 100.00% <100.00%> (ø)
...t-plugin/src/rules/adjacent-overload-signatures.ts 100.00% <ø> (ø)
packages/eslint-plugin/src/rules/array-type.ts 98.52% <100.00%> (-0.05%) ⬇️
packages/eslint-plugin/src/rules/await-thenable.ts 100.00% <ø> (ø)
packages/eslint-plugin/src/rules/ban-ts-comment.ts 97.29% <100.00%> (-0.14%) ⬇️
...ages/eslint-plugin/src/rules/ban-tslint-comment.ts 100.00% <100.00%> (ø)
packages/eslint-plugin/src/rules/ban-types.ts 100.00% <100.00%> (ø)
packages/eslint-plugin/src/rules/block-spacing.ts 100.00% <100.00%> (ø)
packages/eslint-plugin/src/rules/brace-style.ts 95.23% <100.00%> (-0.22%) ⬇️
... and 102 more

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I trust you on the playground selector 🙂 . This is great - really excited to lose the burden of older ESLint support!

@JoshuaKGoldberg
Copy link
Member

I ran a few full text regex searches in .ts files and found some older ESLint compat support:

  • /eslint.*v7/
  • `/eslint.*v8/

Not blocking IMO, but at least something to note as a good followup.

@JamesHenry
Copy link
Member

🎉

@bradzacher bradzacher marked this pull request as ready for review February 5, 2024 22:58
@bradzacher
Copy link
Member Author

@JoshuaKGoldberg I ended up expanding the scope of this to remove the deprecated property usages as well. Pls re-review sir.

JoshuaKGoldberg
JoshuaKGoldberg reviewed Feb 6, 2024
View reviewed changes
package.json
@@ -63,7 +63,6 @@
"@nx/eslint": "17.2.8",
"@nx/jest": "17.2.8",
"@nx/workspace": "17.2.8",
"@prettier/sync": "^0.5.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heck yes async everywhere

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everywhere except eslint-plugin-internal. One day we'll have async plugins . . . .

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A girl dressed in victorian clothing (in the Muppet Christmas Carol movie) happily saying 'Wonderful'

@bradzacher bradzacher merged commit 584db29 into main Feb 6, 2024
@bradzacher bradzacher deleted the v7 branch February 6, 2024 03:33
@bradzacher bradzacher mentioned this pull request Feb 7, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg

@JamesHenry JamesHenry

Assignees
No one assigned
Labels
breaking change This change will require a new major version to be released dependencies Issue about dependencies of the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

📣 Upcoming v7 Major Release
3 participants
@bradzacher @JoshuaKGoldberg @JamesHenry