Skip to content

docs: add FAQ entry about ESLint's --cache #8372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JoshuaKGoldberg merged 1 commit into from
Feb 5, 2024
Merged

docs: add FAQ entry about ESLint's --cache #8372

JoshuaKGoldberg merged 1 commit into from
Feb 5, 2024

Conversation

@JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Feb 4, 2024

PR Checklist

Overview

Adds a direct FAQ entry explaining why --cache is problematic.

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Feb 4, 2024

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Feb 4, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 277a68f
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65bfcb7f0e70240008185afd
😎 Deploy Preview https://deploy-preview-8372--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 83 (🔴 down 7 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud
Copy link

nx-cloud bot commented Feb 4, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 277a68f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 33 targets

Sent with 💌 from NxCloud.

@codecov
Copy link

codecov bot commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8de6ee2) 87.70% compared to head (277a68f) 87.80%.
Report is 31 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8372      +/-   ##
==========================================
+ Coverage   87.70%   87.80%   +0.09%     
==========================================
  Files         397      398       +1     
  Lines       13950    14052     +102     
  Branches     4055     4090      +35     
==========================================
+ Hits        12235    12338     +103     
  Misses       1403     1403              
+ Partials      312      311       -1
Flag Coverage Δ
unittest 87.80% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...t-plugin/src/rules/class-literal-property-style.ts 100.00% <100.00%> (ø)
...eslint-plugin/src/rules/consistent-type-imports.ts 95.28% <ø> (ø)
...es/eslint-plugin/src/rules/no-invalid-void-type.ts 97.91% <ø> (ø)
...slint-plugin/src/rules/no-unnecessary-condition.ts 98.56% <100.00%> (+0.09%) ⬆️
...-plugin/src/rules/no-unnecessary-type-assertion.ts 97.56% <100.00%> (+1.45%) ⬆️
packages/eslint-plugin/src/rules/prefer-find.ts 100.00% <100.00%> (ø)
...-estree/src/parseSettings/getProjectConfigFiles.ts 100.00% <100.00%> (ø)
packages/utils/src/eslint-utils/nullThrows.ts 80.00% <ø> (ø)
packages/utils/src/ts-eslint/Linter.ts 50.00% <ø> (ø)

@JoshuaKGoldberg JoshuaKGoldberg merged commit 847d193 into typescript-eslint:main Feb 5, 2024
@JoshuaKGoldberg JoshuaKGoldberg deleted the docs-faq-against-cache branch February 5, 2024 00:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Docs: type-aware linting is not safe to use with eslint --cache

2 participants

@JoshuaKGoldberg @bradzacher