Skip to content

chore: cleanup test-utils naming/locations #8341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Conversation

bradzacher
Copy link
Member

Overview

More splitting out of #7935.

This cleans up some things with our test naming and locations.
Moves all of our test related code to be within the tests/ folders.
Utils now live under tests/test-utils/.
All tests are now named with .test.ts.

This all makes it easier to target globs to "files that are used in tests"

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Feb 2, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 0d8e99e
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65bc400970ad7a000886b7ba
😎 Deploy Preview https://deploy-preview-8341--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 9 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@bradzacher bradzacher merged commit 45c0cb2 into main Feb 2, 2024
@bradzacher bradzacher deleted the cleanup-test-utils branch February 2, 2024 01:45
danvk pushed a commit to danvk/typescript-eslint that referenced this pull request Feb 4, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant