chore: use nx release #8194

JamesHenry · 2024-01-05T19:25:17Z

For right now, a pinned header at the top of the changelog file is not supported, so I have removed this in every case to avoid confusion once we do the first release after this goes in:

# Change Log

All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

I'll add support for a pinned header like that into nx release after this and we can bring it back if we want

typescript-eslint · 2024-01-05T19:25:20Z

Thanks for the PR, @JamesHenry!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2024-01-05T19:25:22Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`a38f60e`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6599331a96369e00085aa2e0
😎 Deploy Preview	https://deploy-preview-8194--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 96 (🔴 down 2 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

JamesHenry · 2024-01-05T19:41:25Z

packages/ast-spec/project.json

@@ -16,7 +16,6 @@
      "executor": "@nx/eslint:lint",
      "outputs": ["{options.outputFile}"],
      "options": {
-        "lintFilePatterns": ["packages/ast-spec/**/*.{mts,cts,ts,tsx}"],


The patterns are no longer required, the source files of the project are all eligible to be linted

JamesHenry · 2024-01-05T20:33:47Z

@typescript-eslint/triage-team any idea why I am getting these integration-test failures?

JoshuaKGoldberg · 2024-01-05T21:59:26Z

CHANGELOG.md

@@ -1,8 +1,3 @@
-# Change Log


[Question] While we're here, can we change it to # Changelog? I don't know of any other project that uses two words 😄

Ha yeah true

package.json

JoshuaKGoldberg

Awesome to see the Lerna->Nx migration come to a head! 🚀

Requesting changes on moving things to repo-tools and updating the last mention of Lerna from the docs. But I can aquiese if you don't think those should be blocking. 😄

tools/release/release.ts

JoshuaKGoldberg · 2024-01-05T22:08:24Z

tools/release/release.ts

+void (async () => {
+  try {


[Suggestion] We can avoid these wrappings by changing the file extension to .mts and adding .mts to tsconfig.eslint.json.

Suggested change

void (async () => {

try {

I did initially and the lint errors went crazy so I punted on that

Feel free to adjust in a small follow up if you know what the fix is

It's tsconfig.eslint.json explicitly including only .ts files in this folder, not .mts.

tools/release/release.ts

.github/workflows/ci.yml

packages/repo-tools/src/apply-canary-version.mts

tools/release/changelog-renderer.js

package.json

JamesHenry · 2024-01-05T22:50:43Z

@JoshuaKGoldberg any thoughts on the failures?

JoshuaKGoldberg · 2024-01-05T23:20:57Z

Oh right sorry - it looks like #7890 -> #7891... which is unfortunate because the nx-release branch is up to date. Odd. Maybe a caching issue?

package.json

JamesHenry · 2024-01-06T11:47:48Z

@JoshuaKGoldberg @auvred updated per the PR feedback and now everything is passing except for the TSServer tests for eslint-plugin.

I reran it in case it was flakiness, but the failure seems to be consistent. Any ideas please?

https://github.com/typescript-eslint/typescript-eslint/actions/runs/7431162445/job/20221866549?pr=8194

auvred · 2024-01-06T11:49:48Z

Oh, this is a known issue, it's not related to this PR. It should be fixed in #8131 -> #8136

JamesHenry · 2024-01-06T11:51:40Z

Ah cool thanks, pressing ahead with this then while I still have time to focus on it

JamesHenry added 3 commits January 5, 2024 21:32

chore: update to nx 17.2.8

85c2d70

chore: use nx release

5039f60

chore: remove unsupported changelog header for now

7287af9

JamesHenry added 2 commits January 5, 2024 23:31

chore: tmp testing

3c28b60

chore: revert test changes

bed88d3

JamesHenry commented Jan 5, 2024

View reviewed changes

JamesHenry added 2 commits January 6, 2024 00:00

chore: enable automated git operations for nx release changelog

9a23f09

chore: add release script ready for pipeline

2d5600d

JamesHenry marked this pull request as ready for review January 5, 2024 20:33

JoshuaKGoldberg reviewed Jan 5, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

JoshuaKGoldberg reviewed Jan 5, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

JoshuaKGoldberg requested changes Jan 5, 2024

View reviewed changes

JoshuaKGoldberg added the awaiting response label Jan 5, 2024

auvred requested changes Jan 6, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

JamesHenry added 3 commits January 6, 2024 14:28

chore: pr feedback

8b1198a

chore: move TODO comment to fix build

fb5326a

chore: redo lock

a38f60e

JamesHenry merged commit d0977ab into main Jan 6, 2024

JamesHenry deleted the nx-release branch January 6, 2024 11:51

JoshuaKGoldberg mentioned this pull request Jan 6, 2024

chore: rename release.ts to release.mts #8204

Merged

3 tasks

github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: use nx release #8194

chore: use nx release #8194

JamesHenry commented Jan 5, 2024

typescript-eslint bot commented Jan 5, 2024

netlify bot commented Jan 5, 2024 •

edited

Loading

JamesHenry Jan 5, 2024

JamesHenry commented Jan 5, 2024

JoshuaKGoldberg Jan 5, 2024 •

edited

Loading

JamesHenry Jan 5, 2024

JoshuaKGoldberg left a comment

JoshuaKGoldberg Jan 5, 2024

JamesHenry Jan 6, 2024 •

edited

Loading

JoshuaKGoldberg Jan 6, 2024

JamesHenry commented Jan 5, 2024

JoshuaKGoldberg commented Jan 5, 2024

JamesHenry commented Jan 6, 2024 •

edited

Loading

auvred commented Jan 6, 2024

JamesHenry commented Jan 6, 2024

chore: use nx release #8194

chore: use nx release #8194

Conversation

JamesHenry commented Jan 5, 2024

typescript-eslint bot commented Jan 5, 2024

netlify bot commented Jan 5, 2024 • edited Loading

✅ Deploy Preview for typescript-eslint ready!

JamesHenry Jan 5, 2024

Choose a reason for hiding this comment

JamesHenry commented Jan 5, 2024

JoshuaKGoldberg Jan 5, 2024 • edited Loading

Choose a reason for hiding this comment

JamesHenry Jan 5, 2024

Choose a reason for hiding this comment

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

JoshuaKGoldberg Jan 5, 2024

Choose a reason for hiding this comment

JamesHenry Jan 6, 2024 • edited Loading

Choose a reason for hiding this comment

JoshuaKGoldberg Jan 6, 2024

Choose a reason for hiding this comment

JamesHenry commented Jan 5, 2024

JoshuaKGoldberg commented Jan 5, 2024

JamesHenry commented Jan 6, 2024 • edited Loading

auvred commented Jan 6, 2024

JamesHenry commented Jan 6, 2024

netlify bot commented Jan 5, 2024 •

edited

Loading

JoshuaKGoldberg Jan 5, 2024 •

edited

Loading

JamesHenry Jan 6, 2024 •

edited

Loading

JamesHenry commented Jan 6, 2024 •

edited

Loading