Skip to content

fix(eslint-plugin): [@typescript-eslint/typedef] support default value for parameter #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bradzacher merged 3 commits into from
Aug 2, 2019
Merged

fix(eslint-plugin): [@typescript-eslint/typedef] support default value for parameter #785

bradzacher merged 3 commits into from
Aug 2, 2019

Conversation

@octogonz
Copy link
Contributor

@octogonz octogonz commented Jul 31, 2019

Fixes #784

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Jul 31, 2019

Thanks for the PR, @octogonz!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint

@octogonz octogonz mentioned this pull request Jul 31, 2019
Closed
@codecov
Copy link

codecov bot commented Jul 31, 2019 •
edited
Loading

Codecov Report

Merging #785 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #785      +/-   ##
==========================================
+ Coverage    94.2%   94.21%   +<.01%     
==========================================
  Files         112      112              
  Lines        4801     4808       +7     
  Branches     1334     1334              
==========================================
+ Hits         4523     4530       +7     
  Misses        159      159              
  Partials      119      119
Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/typedef.ts 97.22% <100%> (+0.67%) ⬆️

@octogonz
Copy link
Contributor Author

octogonz commented Aug 1, 2019

The code coverage issue was due to TSParameterProperty which was not actually getting checked by typedef. I added a commit that handles TSParameterProperty correctly.

bradzacher
bradzacher approved these changes Aug 2, 2019
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for fixing this

@bradzacher bradzacher merged commit 84916e6 into typescript-eslint:master Aug 2, 2019
@bradzacher bradzacher added the bug Something isn't working label Aug 2, 2019
@mrmlnc mrmlnc mentioned this pull request Aug 29, 2019
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[@typescript-eslint/typedef] broken when used with a default parameter

2 participants

@octogonz @bradzacher