-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
chore: bump dependency versions #7191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
88776bd
to
79661c2
Compare
Did you use nx migrate for this? |
79661c2
to
55f4b55
Compare
@JamesHenry I haven't bumped |
55f4b55
to
452738e
Compare
D’oh sorry I misread your description - yeah we always wanna use Nx migrate for that reason. I can do that in a follow up later |
452738e
to
9ea7916
Compare
9ea7916
to
2439a86
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7191 +/- ##
=======================================
Coverage 87.54% 87.54%
=======================================
Files 377 377
Lines 13181 13172 -9
Branches 3899 3892 -7
=======================================
- Hits 11539 11532 -7
+ Misses 1262 1261 -1
+ Partials 380 379 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
...portEqualsDeclaration/fixtures/external-module-ref-string/snapshots/5-AST-Alignment-AST.shot
Show resolved
Hide resolved
@@ -1,5 +1,12 @@ | |||
import * as execa from 'execa'; | |||
import { $ as $_config } from 'execa'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I might call this $config
...
--- a/node_modules/@microsoft/api-extractor/lib/api/ExtractorConfig.js | ||
+++ b/node_modules/@microsoft/api-extractor/lib/api/ExtractorConfig.js | ||
@@ -669,5 +669,5 @@ ExtractorConfig.FILENAME = 'api-extractor.json'; | ||
@@ -668,6 +668,6 @@ ExtractorConfig.FILENAME = 'api-extractor.json'; | ||
*/ | ||
ExtractorConfig._tsdocBaseFilePath = path.resolve(__dirname, '../../extends/tsdoc-base.json'); | ||
ExtractorConfig._defaultConfig = node_core_library_1.JsonFile.load(path.join(__dirname, '../schemas/api-extractor-defaults.json')); | ||
-ExtractorConfig._declarationFileExtensionRegExp = /\.d\.ts$/i; | ||
+ExtractorConfig._declarationFileExtensionRegExp = /\.d\.(c|m)?ts$/i; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just bumped microsoft/rushstack#4023 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overview
This just does a bump of all our dependencies to pin their versions to the latest in all packages except the website packages.
The remaining outdated packages are intentionally outdated ones
@types/node
- TBH we should probably downgrade this to v16 - given that's the lowest version we support. For now I just left it at the highest v18ts-node
because of the bug (we need to finish migrating off this to tsx tbh)