Skip to content

chore: bump dependency versions #7191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2023
Merged

chore: bump dependency versions #7191

merged 1 commit into from
Jul 12, 2023

Conversation

bradzacher
Copy link
Member

Overview

This just does a bump of all our dependencies to pin their versions to the latest in all packages except the website packages.

The remaining outdated packages are intentionally outdated ones

image

  • nx deps to be upgraded later (cc @JamesHenry)
    • @nrwl/jest
    • @nrwl/nx-cloud
    • @nrwl/workspace
    • @nx/jest
    • @nx/linter
    • @nx/workspace
    • nx
  • prettier has a major to work through
  • @types/node - TBH we should probably downgrade this to v16 - given that's the lowest version we support. For now I just left it at the highest v18
  • ts-node because of the bug (we need to finish migrating off this to tsx tbh)

@bradzacher bradzacher added the dependencies Issue about dependencies of the package label Jul 11, 2023
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Jul 11, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 2439a86
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64ad27219c9c93000853c8aa
😎 Deploy Preview https://deploy-preview-7191--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud
Copy link

nx-cloud bot commented Jul 11, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2439a86. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 31 targets

Sent with 💌 from NxCloud.

@bradzacher bradzacher force-pushed the version-bump-20230711 branch from 88776bd to 79661c2 Compare July 11, 2023 05:56
@JamesHenry
Copy link
Member

Did you use nx migrate for this?

@bradzacher bradzacher force-pushed the version-bump-20230711 branch from 79661c2 to 55f4b55 Compare July 11, 2023 06:48
@bradzacher
Copy link
Member Author

Did you use nx migrate for this?

@JamesHenry I haven't bumped nx in this PR - I figured we could do that separately given that might need nx config changes too.

@bradzacher bradzacher force-pushed the version-bump-20230711 branch from 55f4b55 to 452738e Compare July 11, 2023 06:50
@JamesHenry
Copy link
Member

D’oh sorry I misread your description - yeah we always wanna use Nx migrate for that reason. I can do that in a follow up later

@bradzacher bradzacher force-pushed the version-bump-20230711 branch from 452738e to 9ea7916 Compare July 11, 2023 06:58
@bradzacher bradzacher force-pushed the version-bump-20230711 branch from 9ea7916 to 2439a86 Compare July 11, 2023 09:55
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #7191 (2439a86) into main (9bd171a) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7191   +/-   ##
=======================================
  Coverage   87.54%   87.54%           
=======================================
  Files         377      377           
  Lines       13181    13172    -9     
  Branches     3899     3892    -7     
=======================================
- Hits        11539    11532    -7     
+ Misses       1262     1261    -1     
+ Partials      380      379    -1     
Flag Coverage Δ
unittest 87.54% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

@bradzacher bradzacher marked this pull request as ready for review July 11, 2023 10:15
@@ -1,5 +1,12 @@
import * as execa from 'execa';
import { $ as $_config } from 'execa';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I might call this $config...

--- a/node_modules/@microsoft/api-extractor/lib/api/ExtractorConfig.js
+++ b/node_modules/@microsoft/api-extractor/lib/api/ExtractorConfig.js
@@ -669,5 +669,5 @@ ExtractorConfig.FILENAME = 'api-extractor.json';
@@ -668,6 +668,6 @@ ExtractorConfig.FILENAME = 'api-extractor.json';
*/
ExtractorConfig._tsdocBaseFilePath = path.resolve(__dirname, '../../extends/tsdoc-base.json');
ExtractorConfig._defaultConfig = node_core_library_1.JsonFile.load(path.join(__dirname, '../schemas/api-extractor-defaults.json'));
-ExtractorConfig._declarationFileExtensionRegExp = /\.d\.ts$/i;
+ExtractorConfig._declarationFileExtensionRegExp = /\.d\.(c|m)?ts$/i;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cartoony/drawn ship choppily animated to be bouncing on some waves

@bradzacher bradzacher merged commit 2e30379 into main Jul 12, 2023
@bradzacher bradzacher deleted the version-bump-20230711 branch July 12, 2023 00:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Issue about dependencies of the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants