chore: enable sort-type-constituents internally #7028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
JoshuaKGoldberg
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v6 #7028 +/- ##
=======================================
Coverage 87.43% 87.43%
=======================================
Files 372 372
Lines 12849 12849
Branches 3813 3813
=======================================
Hits 11235 11235
Misses 1237 1237
Partials 377 377
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bradzacher
approved these changes
Jun 24, 2023
bradzacher
approved these changes
Jun 24, 2023
bradzacher
added
1 approval
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Overview
Enables
sort-type-constituentsinternally. This one rule has a lot of reports, so I wanted to get them out of the way before continuing with other to-be-newly-enabled rules.