chore: upgrade to yarn 3 #6162

JamesHenry · 2022-12-03T12:12:03Z

PR Checklist

Addresses an existing open issue: fixes Repo: Can't develop because of yarn1 #6150
That issue was marked as accepting prs
Steps in CONTRIBUTING.md were taken

Overview

Migrates the codebase from yarn v1 to yarn v3, using the node_modules linker - not PnP - to ensure maximum consistency before and after the migration.

I confirmed that there were no issues with lerna publishing by publishing a canary version to verdaccio locally (this will not negatively impact the canary release post-merge):

typescript-eslint · 2022-12-03T12:12:05Z

Thanks for the PR, @JamesHenry!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2022-12-03T12:12:12Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`7d2396e`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/64e11b877623d60008e113be
😎 Deploy Preview	https://deploy-preview-6162--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

nx.json

packages/ast-spec/project.json

packages/shared-fixtures/project.json

packages/website-eslint/project.json

JamesHenry · 2022-12-03T14:35:10Z

@bradzacher @JoshuaKGoldberg please have a play with this, it all looks good to me locally and CI is passing.

Once you are happy and approve the PR please do not merge, so that I can coordinate the update of the automation jobs

packages/eslint-plugin-internal/package.json

tools/postinstall.ts

JoshuaKGoldberg

Looks great, thanks! 🔥

.gitignore

tools/postinstall.ts

bradzacher

once you fix the CI I'm happy with this.
now i'll need to get used to the new console output from yarn sadge

liuxingbaoyu · 2022-12-14T09:06:56Z

Thanks for all this!

nx-cloud · 2023-07-30T12:03:59Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7d2396e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 40 targets

Sent with 💌 from NxCloud.

packages/website-eslint/package.json

JamesHenry · 2023-07-30T14:24:02Z

packages/type-utils/package.json

@@ -52,7 +52,11 @@
  },
  "devDependencies": {
    "@typescript-eslint/parser": "6.2.0",
-    "ajv": "^8.12.0",


I had to downgrade this to match the rest of the workspace, otherwise patch-package hard errors on it

JamesHenry · 2023-07-30T14:27:54Z

packages/utils/package.json

@@ -78,6 +78,10 @@
  },
  "devDependencies": {
    "@typescript-eslint/parser": "6.2.0",
+    "downlevel-dts": "*",
+    "jest": "29.6.1",


Having to match all these jest versions is pretty cumbersome, but required to make the naked jest calls in npm scripts work with modern yarn.

The way they recommend handling this is different and involves sharing scripts between workspaces, or using run -T in front of the script contents, see here:

https://yarnpkg.com/getting-started/qa#how-to-share-scripts-between-workspaces

Somewhat related - we could avoid the need for this entirely if we always let Nx run the tasks through its own executors and then just switch the script contents to be nx test like we did here:

typescript-eslint/packages/scope-manager/package.json

Line 43 in ed8c624

"test": "nx test --code-coverage",

- it would resolve jest for us, and we wouldn't need to bend over backwards to make yarn happy

That sounds good to me! IIRC you'd mentioned this as a potential followup a while back. I'm definitely in favor.

JamesHenry · 2023-07-30T14:28:55Z

packages/eslint-plugin/package.json

@@ -76,15 +76,19 @@
    "@types/prettier": "*",
    "@typescript-eslint/rule-schema-to-typescript-types": "6.2.0",
    "@typescript-eslint/rule-tester": "6.2.0",
-    "ajv": "^6.12.6",
+    "ajv": "^6.10.0",


Changed to match other references

JoshuaKGoldberg · 2023-07-31T02:37:00Z

.github/workflows/nx-migrate.yml

@@ -72,6 +72,9 @@ jobs:
            rm migrations.json
          fi

+          # Run the special nx repair command to ensure config matches latest and greatest
+          npx nx repair


wat

nrwl/nx#18385

(not a blocker, I just am curious what this actually does)

JoshuaKGoldberg · 2023-07-31T02:40:01Z

netlify.toml

@@ -5,7 +5,9 @@
  command = "NX_VERBOSE_LOGGING=true yarn patch-package && yarn nx build website"
 [build.environment]
  NETLIFY_USE_YARN = "true"
-  YARN_FLAGS = "--ignore-scripts"
+  # TODO: adjust these once https://github.com/netlify/build-image/issues/612 is resolved


That awkward moment when the upstream repo is archived without resolving the issue... 🤷

JoshuaKGoldberg

This looks great! I read through and think I understand the strategies and upstream-blocked-todo-workarounds. Also I tried it out locally and -with the caveat I commented in package.json- it seems to work great on my end. Nice! 👏

Only requesting changes because I think we'll need to update the local development docs.

JamesHenry · 2023-08-19T20:36:10Z

@JoshuaKGoldberg Brought it back up to date and updated the local development guide. Hopefully we can merge now!

JoshuaKGoldberg

Tried it out locally again and it all works great! No need for me to manually run .cjs files from the repo. Thanks! Awesome stuff @JamesHenry 🚀

JamesHenry commented Dec 3, 2022

View reviewed changes

nx.json Outdated Show resolved Hide resolved

JamesHenry force-pushed the yarn-3 branch 2 times, most recently from 6bed2f3 to d8a5d74 Compare December 3, 2022 14:05

JamesHenry commented Dec 3, 2022

View reviewed changes

packages/ast-spec/project.json Outdated Show resolved Hide resolved

JamesHenry commented Dec 3, 2022

View reviewed changes

packages/shared-fixtures/project.json Outdated Show resolved Hide resolved

JamesHenry commented Dec 3, 2022

View reviewed changes

packages/website-eslint/project.json Outdated Show resolved Hide resolved

JamesHenry force-pushed the yarn-3 branch from d8a5d74 to 3446d37 Compare December 3, 2022 14:06

JamesHenry requested review from bradzacher and JoshuaKGoldberg December 3, 2022 14:34

JamesHenry marked this pull request as ready for review December 3, 2022 14:34

JoshuaKGoldberg reviewed Dec 3, 2022

View reviewed changes

packages/eslint-plugin-internal/package.json Show resolved Hide resolved

JoshuaKGoldberg reviewed Dec 3, 2022

View reviewed changes

tools/postinstall.ts Outdated Show resolved Hide resolved

JoshuaKGoldberg previously approved these changes Dec 3, 2022

View reviewed changes

JoshuaKGoldberg reviewed Dec 3, 2022

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

JamesHenry dismissed JoshuaKGoldberg’s stale review via b549f4e December 4, 2022 11:05

bradzacher reviewed Dec 7, 2022

View reviewed changes

tools/postinstall.ts Outdated Show resolved Hide resolved

bradzacher previously approved these changes Dec 7, 2022

View reviewed changes

JamesHenry dismissed bradzacher’s stale review via ca3d928 December 8, 2022 08:49

bradzacher previously approved these changes Dec 12, 2022

View reviewed changes

bradzacher dismissed their stale review via be1a86c December 14, 2022 00:20

bradzacher previously approved these changes Dec 14, 2022

View reviewed changes

bradzacher added repo maintenance 1 approval labels Jan 30, 2023

liuxingbaoyu mentioned this pull request Feb 19, 2023

Repo: Add Windows testing to CI #6490

Closed

JamesHenry dismissed bradzacher’s stale review via e7b6dbf February 20, 2023 12:06

JamesHenry force-pushed the yarn-3 branch from a4f08a7 to e7b6dbf Compare February 20, 2023 12:06

JamesHenry commented Jul 30, 2023

View reviewed changes

packages/website-eslint/package.json Show resolved Hide resolved

JamesHenry force-pushed the yarn-3 branch 2 times, most recently from c129fc4 to b87880b Compare July 30, 2023 12:40

typescript-eslint deleted a comment from nx-cloud bot Jul 30, 2023

JamesHenry force-pushed the yarn-3 branch from 3f0f996 to ed8c624 Compare July 30, 2023 14:21

JamesHenry commented Jul 30, 2023

View reviewed changes

JamesHenry removed the awaiting response label Jul 30, 2023

JamesHenry mentioned this pull request Jul 30, 2023

chore(deps): update nx to v16.7.2 #7305

Merged

1 task

JamesHenry requested review from JoshuaKGoldberg and bradzacher July 30, 2023 15:10

JoshuaKGoldberg reviewed Jul 31, 2023

View reviewed changes

JoshuaKGoldberg requested changes Jul 31, 2023

View reviewed changes

JoshuaKGoldberg added the awaiting response label Jul 31, 2023

chore: update repo to yarn 3

371eec3

JamesHenry force-pushed the yarn-3 branch from ed8c624 to 371eec3 Compare August 19, 2023 19:40

JamesHenry added 2 commits August 19, 2023 23:42

chore: align jest versions with root

2a24391

chore: align more jest package versions

7d2396e

JamesHenry requested a review from JoshuaKGoldberg August 19, 2023 20:35

github-actions bot removed the awaiting response label Aug 19, 2023

JoshuaKGoldberg approved these changes Aug 20, 2023

View reviewed changes

JoshuaKGoldberg merged commit 2e1cfd5 into main Aug 20, 2023

JoshuaKGoldberg deleted the yarn-3 branch August 20, 2023 22:10

JoshuaKGoldberg mentioned this pull request Aug 20, 2023

Repo: Prettier tooling still runs yarn 1's --ignore-scripts #7513

Closed

github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: upgrade to yarn 3 #6162

chore: upgrade to yarn 3 #6162

JamesHenry commented Dec 3, 2022 •

edited

Loading

typescript-eslint bot commented Dec 3, 2022

netlify bot commented Dec 3, 2022 •

edited

Loading

JamesHenry commented Dec 3, 2022

JoshuaKGoldberg left a comment

bradzacher left a comment •

edited

Loading

liuxingbaoyu commented Dec 14, 2022

nx-cloud bot commented Jul 30, 2023 •

edited

Loading

JamesHenry Jul 30, 2023 •

edited

Loading

JamesHenry Jul 30, 2023 •

edited

Loading

JoshuaKGoldberg Jul 31, 2023

JamesHenry Jul 30, 2023

JoshuaKGoldberg Jul 31, 2023

JoshuaKGoldberg Jul 31, 2023

JoshuaKGoldberg Jul 31, 2023

JoshuaKGoldberg left a comment

JamesHenry commented Aug 19, 2023

JoshuaKGoldberg left a comment •

edited

Loading

chore: upgrade to yarn 3 #6162

chore: upgrade to yarn 3 #6162

Conversation

JamesHenry commented Dec 3, 2022 • edited Loading

PR Checklist

Overview

typescript-eslint bot commented Dec 3, 2022

netlify bot commented Dec 3, 2022 • edited Loading

✅ Deploy Preview for typescript-eslint ready!

JamesHenry commented Dec 3, 2022

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

bradzacher left a comment • edited Loading

Choose a reason for hiding this comment

liuxingbaoyu commented Dec 14, 2022

nx-cloud bot commented Jul 30, 2023 • edited Loading

☁️ Nx Cloud Report

JamesHenry Jul 30, 2023 • edited Loading

Choose a reason for hiding this comment

JamesHenry Jul 30, 2023 • edited Loading

Choose a reason for hiding this comment

JoshuaKGoldberg Jul 31, 2023

Choose a reason for hiding this comment

JamesHenry Jul 30, 2023

Choose a reason for hiding this comment

JoshuaKGoldberg Jul 31, 2023

Choose a reason for hiding this comment

JoshuaKGoldberg Jul 31, 2023

Choose a reason for hiding this comment

JoshuaKGoldberg Jul 31, 2023

Choose a reason for hiding this comment

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

JamesHenry commented Aug 19, 2023

JoshuaKGoldberg left a comment • edited Loading

Choose a reason for hiding this comment

JamesHenry commented Dec 3, 2022 •

edited

Loading

netlify bot commented Dec 3, 2022 •

edited

Loading

bradzacher left a comment •

edited

Loading

nx-cloud bot commented Jul 30, 2023 •

edited

Loading

JamesHenry Jul 30, 2023 •

edited

Loading

JamesHenry Jul 30, 2023 •

edited

Loading

JoshuaKGoldberg left a comment •

edited

Loading