Skip to content

chore: remove unnecessary project names from nx commands #6054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

JamesHenry
Copy link
Member

@JamesHenry JamesHenry commented Nov 21, 2022

Overview

The Nx CLI does the "right thing" when it is run within a package's directory - it infers the relevant project and looks up the target script name based on that.

Therefore we can remove any cding and explicit referencing of project names we currently do within package npm script aliases

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JamesHenry!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Nov 21, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ee83927. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Nov 21, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit ee83927
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/637b9904203cf1000aded4e6
😎 Deploy Preview https://deploy-preview-6054--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 !

@JamesHenry JamesHenry enabled auto-merge (squash) November 21, 2022 15:33
@JamesHenry JamesHenry merged commit 426c2f9 into main Nov 21, 2022
@JamesHenry JamesHenry deleted the clean-npm-sciprts branch November 21, 2022 15:42
omril1 pushed a commit to omril1/typescript-eslint that referenced this pull request Nov 23, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants