Skip to content

docs(naming-conventions): Alphabetizing inline lists #5940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JoshuaKGoldberg merged 2 commits into from
Nov 12, 2022
Merged

docs(naming-conventions): Alphabetizing inline lists #5940

JoshuaKGoldberg merged 2 commits into from
Nov 12, 2022

Conversation

@vaishnav-mk
Copy link
Contributor

@vaishnav-mk vaishnav-mk commented Nov 8, 2022 •
edited by JoshuaKGoldberg
Loading

PR Checklist

Overview

This pr alphabetizes inline lists for naming convention rules

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Nov 8, 2022

Thanks for the PR, @vaishnav-mk!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Nov 8, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4335415. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Nov 8, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 4335415
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/636faf92cbb3f30008594212
😎 Deploy Preview https://deploy-preview-5940--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Nov 12, 2022
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start, thanks @vaishnav-mk! 🚀

I'll note that I'd hoped for "both actual * lists and comma-sorted inline ones" in the issue, so I'll keep it open, and added #5934 (comment). If you want to send a followup PR that sorts list items too, that'd be great!

@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) November 12, 2022 14:42
@JoshuaKGoldberg JoshuaKGoldberg merged commit 91d71bc into typescript-eslint:main Nov 12, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vaishnav-mk @JoshuaKGoldberg