Skip to content

chore: nx migrate latest (14.8.4) #5798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2022
Merged

chore: nx migrate latest (14.8.4) #5798

merged 2 commits into from
Oct 13, 2022

Conversation

JamesHenry
Copy link
Member

I ran this manually, but soon this will be done automatically in renovate PRs once #5797 is in place.

Here you see examples of how Nx updates its own config files automatically when best practices/APIs change 🎉

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JamesHenry!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@nx-cloud
Copy link

nx-cloud bot commented Oct 10, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit eb142ca. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 25 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Oct 10, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit eb142ca
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63471820a908e5000977ad65
😎 Deploy Preview https://deploy-preview-5798--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JamesHenry JamesHenry mentioned this pull request Oct 10, 2022
Merged
JamesHenry
JamesHenry commented Oct 10, 2022
View reviewed changes
nx.json
]
"targetDefaults": {
"build": {
"dependsOn": ["^build"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a more concise way of expressing the same thing.

The ^ means "of my dependencies".

So here build tasks depend on the build tasks of their dependencies

@codecov
Copy link

codecov bot commented Oct 12, 2022 •
edited
Loading

Codecov Report

Merging #5798 (eb142ca) into main (c5beaa2) will decrease coverage by 2.47%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5798      +/-   ##
==========================================
- Coverage   93.82%   91.34%   -2.48%     
==========================================
  Files         134      360     +226     
  Lines        1506    12010   +10504     
  Branches      226     3498    +3272     
==========================================
+ Hits         1413    10971    +9558     
- Misses         60      743     +683     
- Partials       33      296     +263
Flag Coverage Δ
unittest 91.34% <ø> (-2.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-plugin/src/rules/restrict-template-expressions.ts 100.00% <0.00%> (ø)
...s/utils/src/eslint-utils/batchedSingleLineTests.ts 91.66% <0.00%> (ø)
...es/eslint-plugin/src/rules/object-curly-spacing.ts 100.00% <0.00%> (ø)
...int-plugin/src/rules/consistent-type-assertions.ts 88.88% <0.00%> (ø)
packages/utils/src/eslint-utils/deepMerge.ts 100.00% <0.00%> (ø)
packages/typescript-estree/src/simple-traverse.ts 75.00% <0.00%> (ø)
...t-plugin/src/rules/class-literal-property-style.ts 100.00% <0.00%> (ø)
packages/typescript-estree/src/getModifiers.ts 60.86% <0.00%> (ø)
...ges/typescript-estree/src/create-program/shared.ts 83.33% <0.00%> (ø)
...ages/eslint-plugin/src/rules/no-unsafe-argument.ts 83.95% <0.00%> (ø)
... and 216 more

@JamesHenry JamesHenry marked this pull request as ready for review October 12, 2022 16:25
@JamesHenry JamesHenry changed the title chore: nx migrate latest (14.8.3) chore: nx migrate latest (14.8.4) Oct 12, 2022
@JamesHenry JamesHenry merged commit 56f89d6 into main Oct 13, 2022
@JamesHenry JamesHenry deleted the nx-migrate-latest branch October 13, 2022 16:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamesHenry @bradzacher