Skip to content

Conversation

@armano2
Copy link
Collaborator

@armano2 armano2 commented Jan 14, 2019

This PR enables 2 additional typescript error codes for invalid usage of ! and ?

  • TS1162: An object member cannot be declared optional.
  • TS1255: A definite assignment assertion '!' is not permitted in this context.

@codecov
Copy link

codecov bot commented Jan 14, 2019

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #5   +/-   ##
=======================================
  Coverage   94.16%   94.16%           
=======================================
  Files          13       13           
  Lines        1698     1698           
  Branches      327      327           
=======================================
  Hits         1599     1599           
  Misses         60       60           
  Partials       39       39
Impacted Files Coverage Δ
packages/typescript-estree/src/semantic-errors.ts 77.77% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 593e381...fca735e. Read the comment docs.

@armano2 armano2 changed the title fix(estree): enable error codes TS1162 and TS1255 fix(typescript-estree): enable error codes TS1162 and TS1255 Jan 16, 2019
@JamesHenry JamesHenry merged commit 2206ed6 into typescript-eslint:master Jan 16, 2019
@armano2 armano2 deleted the error-codes branch January 16, 2019 02:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants