fix: mark only leading string expressions as directives #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- all leading string expressions in blocks should be marked as directives unless there is expression of different type before it - directives does not have to be unique
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
=======================================
Coverage 93.71% 93.71%
=======================================
Files 8 8
Lines 1401 1401
Branches 325 325
=======================================
Hits 1313 1313
Misses 49 49
Partials 39 39
Continue to review full report at Codecov.
|
JamesHenry
approved these changes
Jan 14, 2019
JamesHenry
added a commit
that referenced
this pull request
Jan 17, 2019
BREAKING CHANGE: This plugin now requires TSLint 5, and the user must now separately install and manage their own TSLint dependency fix #3
JamesHenry
added a commit
that referenced
this pull request
Jan 17, 2019
BREAKING CHANGE: This plugin now requires TSLint 5, and the user must now separately install and manage their own TSLint dependency fix #3
JamesHenry
pushed a commit
that referenced
this pull request
Jan 17, 2019
…y modifiers such as public, private, and protected. (refs #4)
JamesHenry
pushed a commit
that referenced
this pull request
Jan 17, 2019
…y modifiers such as public, private, and protected. (refs #4)
JamesHenry
pushed a commit
that referenced
this pull request
Jan 18, 2019
…y modifiers such as public, private, and protected. (refs #4)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes detection of directives: