Import eslint-plugin-tslint #35
Conversation
BREAKING CHANGE: This plugin now requires TSLint 5, and the user must now separately install and manage their own TSLint dependency fix #3
* chore(package): update prettier-eslint-cli to version 4.4.2 Closes #13 * chore(package): update lockfile https://npm.im/greenkeeper-lockfile
# [3.1.0](JamesHenry/eslint-plugin-tslint@v3.0.0...v3.1.0) (2018-10-19) ### Bug Fixes * Tiny lint note elimination ([a731838](JamesHenry/eslint-plugin-tslint@a731838)) ### Features * Support for tslint property ([18a4afb](JamesHenry/eslint-plugin-tslint@18a4afb)), closes [#40](JamesHenry/eslint-plugin-tslint#40)
JamesHenry
force-pushed
the
import-eslint-plugin-tslint
branch
from
1408708 to
74d628b
Compare
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
==========================================
- Coverage 93.77% 93.73% -0.04%
==========================================
Files 11 13 +2
Lines 1686 1724 +38
Branches 376 381 +5
==========================================
+ Hits 1581 1616 +35
- Misses 55 56 +1
- Partials 50 52 +2
Continue to review full report at Codecov.
|
|
I have updated the plugin to not build its own TypeScript Program and leverage parserServices now that @uniqueiniquity's PR is in :) Ben, I would be interested to know if this plugin is useful to you as you transition between TSLint and ESLint. I envisage it being useful for a hybrid state where some custom rules etc have not been converted. Let me know your thoughts! |
|
P.S. Docs are not up to date, I would like to update all the packages' docs at once before the first release from the monorepo |
|
after @j-f1 finish working on tests for eslint with jest we should convert them in this package to (https://github.com/bradzacher/eslint-plugin-typescript/issues/242) |
| const tslintConfig = memoize( | ||
| ( | ||
| lintFile: string, | ||
| tslintRules: RawRulesConfig, |
There was a problem hiding this comment.
you can use Record<string, RawRuleConfig) here
|
My current setup doesn’t use Jest, it just runs the tests directly in a loop. |
|
@JamesHenry I absolutely agree about this plugin being useful as a transition tool, especially for custom rule sets that users or organizations may have. |
|
It is 500ing when I try and rebase merge 😭 I have written to GitHub support |
This builds on #34 and will not work until it does.#34 has been merged
See #35 (comment)
and #35 (comment)