Skip to content

Conversation

@bradzacher
Copy link
Member

BREAKING CHANGE:

Fixes #1420

BREAKING CHANGE:
Fixes #1420
@bradzacher bradzacher added breaking change This change will require a new major version to be released dependencies Issue about dependencies of the package labels May 10, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher linked an issue May 10, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 10, 2020

Codecov Report

Merging #1997 into v3 will decrease coverage by 0.03%.
The diff coverage is 87.09%.

@@            Coverage Diff             @@
##               v3    #1997      +/-   ##
==========================================
- Coverage   93.91%   93.87%   -0.04%     
==========================================
  Files         171      172       +1     
  Lines        7787     7802      +15     
  Branches     2238     2237       -1     
==========================================
+ Hits         7313     7324      +11     
- Misses        217      221       +4     
  Partials      257      257              
Flag Coverage Δ
#unittest 93.87% <87.09%> (-0.04%) ⬇️
Impacted Files Coverage Δ
...xperimental-utils/src/eslint-utils/applyDefault.ts 100.00% <ø> (ø)
.../experimental-utils/src/ts-eslint-scope/analyze.ts 100.00% <ø> (ø)
packages/eslint-plugin/src/util/objectIterators.ts 66.66% <66.66%> (ø)
packages/eslint-plugin/src/rules/ban-types.ts 100.00% <100.00%> (ø)
...ackages/eslint-plugin/src/rules/member-ordering.ts 98.46% <100.00%> (ø)
...slint-plugin/src/rules/no-unnecessary-condition.ts 99.15% <100.00%> (ø)

@bradzacher bradzacher merged commit a6e047f into v3 May 10, 2020
@bradzacher bradzacher deleted the v3-node-versions branch May 10, 2020 00:45
bradzacher added a commit that referenced this pull request May 11, 2020
bradzacher added a commit that referenced this pull request May 14, 2020
bradzacher added a commit that referenced this pull request May 17, 2020
bradzacher added a commit that referenced this pull request May 21, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

breaking change This change will require a new major version to be released dependencies Issue about dependencies of the package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NodeJS v8 EOL at begin of Jan 2020

2 participants