Skip to content

feat(eslint-plugin): update eslint-recommended set #1996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bradzacher merged 1 commit into from
May 10, 2020
Merged

feat(eslint-plugin): update eslint-recommended set #1996

bradzacher merged 1 commit into from
May 10, 2020

Conversation

@bradzacher
Copy link
Member

@bradzacher bradzacher commented May 9, 2020 •
edited
Loading

BREAKING CHANGE:

Closes #1273

@bradzacher bradzacher added enhancement New feature or request breaking change This change will require a new major version to be released labels May 9, 2020
@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented May 9, 2020

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added the recommended-rules Discussion about recommended rule sets label May 9, 2020
@codecov
Copy link

codecov bot commented May 9, 2020

Codecov Report

Merging #1996 into v3 will decrease coverage by 0.03%.
The diff coverage is 87.09%.

@@            Coverage Diff             @@
##               v3    #1996      +/-   ##
==========================================
- Coverage   93.91%   93.87%   -0.04%     
==========================================
  Files         171      172       +1     
  Lines        7787     7802      +15     
  Branches     2238     2237       -1     
==========================================
+ Hits         7313     7324      +11     
- Misses        217      221       +4     
  Partials      257      257
Flag Coverage Δ
#unittest 93.87% <87.09%> (-0.04%) ⬇️
Impacted Files Coverage Δ
...es/eslint-plugin/src/configs/eslint-recommended.ts 100.00% <ø> (ø)
...xperimental-utils/src/eslint-utils/applyDefault.ts 100.00% <ø> (ø)
.../experimental-utils/src/ts-eslint-scope/analyze.ts 100.00% <ø> (ø)
packages/eslint-plugin/src/util/objectIterators.ts 66.66% <66.66%> (ø)
packages/eslint-plugin/src/rules/ban-types.ts 100.00% <100.00%> (ø)
...ackages/eslint-plugin/src/rules/member-ordering.ts 98.46% <100.00%> (ø)
...slint-plugin/src/rules/no-unnecessary-condition.ts 99.15% <100.00%> (ø)

@bradzacher bradzacher merged commit 475036c into v3 May 10, 2020
@bradzacher bradzacher deleted the v3-eslint-recommend branch May 10, 2020 00:17
@bradzacher bradzacher linked an issue May 10, 2020 that may be closed by this pull request
Changes to the eslint-recommended ruleset for 3.0.0 #1273
Closed
bradzacher added a commit that referenced this pull request May 11, 2020
@bradzacher
feat(eslint-plugin): update eslint-recommended set (#1996)
0b0b499
bradzacher added a commit that referenced this pull request May 14, 2020
@bradzacher
feat(eslint-plugin): update eslint-recommended set (#1996)
36fe02a
bradzacher added a commit that referenced this pull request May 17, 2020
@bradzacher
feat(eslint-plugin): update eslint-recommended set (#1996)
225b3fc
bradzacher added a commit that referenced this pull request May 21, 2020
@bradzacher
feat(eslint-plugin): update eslint-recommended set (#1996)
9a96e18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

breaking change This change will require a new major version to be released enhancement New feature or request recommended-rules Discussion about recommended rule sets

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Changes to the eslint-recommended ruleset for 3.0.0

2 participants

@bradzacher