Skip to content

fix(typescript-estree): fix persisted parse for relative paths#1424

Merged
bradzacher merged 10 commits intotypescript-eslint:masterfrom
armano2:1303-fix
Jan 12, 2020
Merged

fix(typescript-estree): fix persisted parse for relative paths#1424
bradzacher merged 10 commits intotypescript-eslint:masterfrom
armano2:1303-fix

Conversation

@armano2
Copy link
Copy Markdown
Collaborator

@armano2 armano2 commented Jan 10, 2020 •
edited
Loading

Issue #1303 seams to be related to resolution of relative paths in watch part of persisted parse.

Parsing error: "parserOptions.project" has been set for @typescript-eslint/parser.
The file does not match your project config: src\bar.ts.
The file must be included in at least one of the projects provided.

its possible that this is different unrelated issue

Tasks:

fixes #1303

@typescript-eslint

This comment has been minimized.

Sign in to view
armano2
armano2 commented Jan 10, 2020
View reviewed changes
Comment thread packages/typescript-estree/tests/lib/persistentParse.ts Outdated
@armano2 armano2 changed the title fix(typescript-estree): fix persisted parse for vue files fix(typescript-estree): fix persisted parse for relative paths Jan 10, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 10, 2020 •
edited
Loading

Codecov Report

Merging #1424 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1424      +/-   ##
==========================================
- Coverage   94.45%   94.45%   -0.01%     
==========================================
  Files         142      142              
  Lines        6082     6081       -1     
  Branches     1727     1727              
==========================================
- Hits         5745     5744       -1     
  Misses        183      183              
  Partials      154      154
Impacted Files Coverage Δ
...pt-estree/src/create-program/createWatchProgram.ts 91.17% <ø> (-0.06%) ⬇️
...ages/eslint-plugin/src/rules/default-param-last.ts 100% <100%> (ø) ⬆️
packages/eslint-plugin/src/rules/index.ts 100% <100%> (ø) ⬆️

armano2
armano2 commented Jan 11, 2020
View reviewed changes
Comment thread packages/typescript-estree/src/parser.ts
import { Extra, TSESTreeOptions, ParserServices } from './parser-options';
import { getFirstSemanticOrSyntacticError } from './semantic-or-syntactic-errors';
import { TSESTree } from './ts-estree';
import { ensureAbsolutePath } from './create-program/shared';
Copy link
Copy Markdown
Collaborator Author

@armano2 armano2 Jan 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't like this, maybe i should move it somewhere else

@armano2 armano2 mentioned this pull request Jan 11, 2020
Closed
armano2
armano2 commented Jan 11, 2020
View reviewed changes
Comment thread packages/typescript-estree/src/create-program/createWatchProgram.ts
cb(current!, ts.FileWatcherEventKind.Changed);
});
hasCallback = true;
break;
Copy link
Copy Markdown
Collaborator Author

@armano2 armano2 Jan 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removal of his line fixes issue with vscode, but i'm unable to test this

armano2 added a commit that referenced this pull request Jan 11, 2020
@armano2
test(eslint-plugin): update filename from relative to absolute path
8997b93 
this should be fixed when #1424 gets merged
@armano2 armano2 mentioned this pull request Jan 11, 2020
Merged
@armano2 armano2 self-assigned this Jan 12, 2020
@armano2 armano2 added bug Something isn't working package: typescript-estree Issues related to @typescript-eslint/typescript-estree labels Jan 12, 2020
bradzacher
bradzacher approved these changes Jan 12, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for working on this

@bradzacher bradzacher merged commit 9720d2c into typescript-eslint:master Jan 12, 2020
@armano2 armano2 deleted the 1303-fix branch January 12, 2020 22:41
@armano2 armano2 mentioned this pull request Jan 12, 2020
Merged
@armano2 armano2 mentioned this pull request Jan 28, 2020
Closed
This was referenced Feb 8, 2020
Closed
Closed
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees

@armano2 armano2

Labels

bug Something isn't working package: typescript-estree Issues related to @typescript-eslint/typescript-estree

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Newly created Vue SFC File: Parsing error: "parserOptions.project" has been set for @typescript-eslint/parser

2 participants

@armano2 @bradzacher