Skip to content

fix(typescript-estree): parsing of deeply nested new files in new folder#1412

Merged
bradzacher merged 6 commits intotypescript-eslint:masterfrom
armano2:1394-error-test
Jan 8, 2020
Merged

fix(typescript-estree): parsing of deeply nested new files in new folder#1412
bradzacher merged 6 commits intotypescript-eslint:masterfrom
armano2:1394-error-test

Conversation

@armano2
Copy link
Copy Markdown
Collaborator

@armano2 armano2 commented Jan 8, 2020 •
edited
Loading

Context:

Currently ** is resolved only as directory, it means that for ./**/* paths /src/test.ts, /test.ts is going to work but /src/test/test.ts will not.

This is edge case and happens when you setup includes with **.

Config example:

// tsconfig.extend.json
{
  "include": ["src"],
}
// tsconfig.json
{
  "extends": "./tsconfig.extend.json",
  "include": ["./**/*"],
}

fixes #1394

@armano2 armano2 requested a review from bradzacher January 8, 2020 00:26
@typescript-eslint

This comment has been minimized.

Sign in to view
@armano2 armano2 changed the title add test file with nested directory test(typescript-estree): add test file with nested directory Jan 8, 2020
armano2
armano2 commented Jan 8, 2020
View reviewed changes
Comment thread packages/typescript-estree/tests/lib/persistentParse.ts Outdated
@armano2 armano2 changed the base branch from 1394-tests to master January 8, 2020 00:54
@armano2 armano2 changed the title test(typescript-estree): add test file with nested directory fix(typescript-estree): mark directories as changed when used with asterisks Jan 8, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 8, 2020 •
edited
Loading

Codecov Report

Merging #1412 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1412      +/-   ##
==========================================
+ Coverage   94.58%   94.58%   +<.01%     
==========================================
  Files         140      140              
  Lines        6057     6058       +1     
  Branches     1723     1723              
==========================================
+ Hits         5729     5730       +1     
  Misses        181      181              
  Partials      147      147
Impacted Files Coverage Δ
...pt-estree/src/create-program/createWatchProgram.ts 92.35% <100%> (+0.04%) ⬆️

@armano2 armano2 changed the title fix(typescript-estree): mark directories as changed when used with asterisks fix(typescript-estree): mark directories as changed when include has ** Jan 8, 2020
bradzacher
bradzacher requested changes Jan 8, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one suggestion, just to better integrate it

Comment thread packages/typescript-estree/tests/lib/persistentParse.ts Outdated
@armano2 armano2 changed the title fix(typescript-estree): mark directories as changed when include has ** fix(typescript-estree): parsing of deeply nested new files in new folder Jan 8, 2020
bradzacher
bradzacher approved these changes Jan 8, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, great work figuring out this hard to repro bug.
thanks so much!

@bradzacher bradzacher merged commit 206c94b into typescript-eslint:master Jan 8, 2020
@armano2 armano2 deleted the 1394-error-test branch January 8, 2020 21:28
@armano2 armano2 mentioned this pull request Jan 8, 2020
Closed
@armano2 armano2 mentioned this pull request Jan 28, 2020
Closed
This was referenced Feb 8, 2020
Closed
Closed
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

IDE Parsing error when using overlapping globs

2 participants

@armano2 @bradzacher