Skip to content

fix(ts-estree): include modifiers in exported node range #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JamesHenry merged 2 commits into from
Jan 24, 2019
Merged

fix(ts-estree): include modifiers in exported node range #133

JamesHenry merged 2 commits into from
Jan 24, 2019

Conversation

@armano2
Copy link
Collaborator

@armano2 armano2 commented Jan 23, 2019 •
edited
Loading

This PR fixes range of exported nodes with modifiers,

async keyword was not included into range of FunctionExpression

export async function bar() {}

@armano2 armano2 requested a review from JamesHenry January 23, 2019 20:30
@armano2 armano2 self-assigned this Jan 23, 2019
@armano2 armano2 added the bug Something isn't working label Jan 23, 2019
@JamesHenry JamesHenry merged commit d8243b4 into typescript-eslint:master Jan 24, 2019
@armano2 armano2 deleted the export-range-issue branch January 24, 2019 13:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

Assignees

@armano2 armano2

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@armano2 @JamesHenry