fix(eslint-plugin): [no-useless-default-assignment] reduce param index to ts this handling#11949
Merged
JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfrom Feb 2, 2026
Merged
Conversation
The es tree node has the this parm in the signature while the ts nodes have explicit param for that.
Contributor
|
Thanks for the PR, @chrros95! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit e28434e
☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. Please upload reports for the commit e28434e to get more accurate results. Additional details and impacted files@@ Coverage Diff @@
## main #11949 +/- ##
==========================================
- Coverage 90.80% 90.73% -0.08%
==========================================
Files 531 527 -4
Lines 54637 53681 -956
Branches 9228 9027 -201
==========================================
- Hits 49611 48705 -906
+ Misses 5015 4963 -52
- Partials 11 13 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
JoshuaKGoldberg
added
the
1 approval
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Feb 10, 2026
| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.54.0 | 8.55.0 | | npm | @typescript-eslint/parser | 8.54.0 | 8.55.0 | ## [v8.55.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8550-2026-02-09) ##### 🚀 Features - **utils:** deprecate defaultOptions in favor of meta.defaultOptions ([#11992](typescript-eslint/typescript-eslint#11992)) ##### 🩹 Fixes - **eslint-plugin:** \[no-useless-default-assignment] reduce param index to ts this handling ([#11949](typescript-eslint/typescript-eslint#11949)) - **eslint-plugin:** \[no-useless-default-assignment] report unnecessary defaults in ternary expressions ([#11984](typescript-eslint/typescript-eslint#11984)) - **eslint-plugin:** \[no-useless-default-assignment] require strictNullChecks ([#11966](typescript-eslint/typescript-eslint#11966), [#12000](typescript-eslint/typescript-eslint#12000)) - **eslint-plugin:** \[no-unused-vars] remove trailing newline when removing entire import ([#11990](typescript-eslint/typescript-eslint#11990)) ##### ❤️ Thank You - Christian Rose [@chrros95](https://github.com/chrros95) - Josh Goldberg - Maria Solano [@MariaSolOs](https://github.com/MariaSolOs) - Minyeong Kim [@minyeong981](https://github.com/minyeong981) - SungHyun627 [@SungHyun627](https://github.com/SungHyun627) - Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw) See [GitHub Releases](https://github.com/typescript-eslint/typescript-eslint/releases/tag/v8.55.0) for more information. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Feb 10, 2026
| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.54.0 | 8.55.0 | | npm | @typescript-eslint/parser | 8.54.0 | 8.55.0 | ## [v8.55.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8550-2026-02-09) ##### 🚀 Features - **utils:** deprecate defaultOptions in favor of meta.defaultOptions ([#11992](typescript-eslint/typescript-eslint#11992)) ##### 🩹 Fixes - **eslint-plugin:** \[no-useless-default-assignment] reduce param index to ts this handling ([#11949](typescript-eslint/typescript-eslint#11949)) - **eslint-plugin:** \[no-useless-default-assignment] report unnecessary defaults in ternary expressions ([#11984](typescript-eslint/typescript-eslint#11984)) - **eslint-plugin:** \[no-useless-default-assignment] require strictNullChecks ([#11966](typescript-eslint/typescript-eslint#11966), [#12000](typescript-eslint/typescript-eslint#12000)) - **eslint-plugin:** \[no-unused-vars] remove trailing newline when removing entire import ([#11990](typescript-eslint/typescript-eslint#11990)) ##### ❤️ Thank You - Christian Rose [@chrros95](https://github.com/chrros95) - Josh Goldberg - Maria Solano [@MariaSolOs](https://github.com/MariaSolOs) - Minyeong Kim [@minyeong981](https://github.com/minyeong981) - SungHyun627 [@SungHyun627](https://github.com/SungHyun627) - Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw) See [GitHub Releases](https://github.com/typescript-eslint/typescript-eslint/releases/tag/v8.55.0) for more information. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Feb 11, 2026
| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.54.0 | 8.55.0 | | npm | @typescript-eslint/parser | 8.54.0 | 8.55.0 | ## [v8.55.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8550-2026-02-09) ##### 🚀 Features - **utils:** deprecate defaultOptions in favor of meta.defaultOptions ([#11992](typescript-eslint/typescript-eslint#11992)) ##### 🩹 Fixes - **eslint-plugin:** \[no-useless-default-assignment] reduce param index to ts this handling ([#11949](typescript-eslint/typescript-eslint#11949)) - **eslint-plugin:** \[no-useless-default-assignment] report unnecessary defaults in ternary expressions ([#11984](typescript-eslint/typescript-eslint#11984)) - **eslint-plugin:** \[no-useless-default-assignment] require strictNullChecks ([#11966](typescript-eslint/typescript-eslint#11966), [#12000](typescript-eslint/typescript-eslint#12000)) - **eslint-plugin:** \[no-unused-vars] remove trailing newline when removing entire import ([#11990](typescript-eslint/typescript-eslint#11990)) ##### ❤️ Thank You - Christian Rose [@chrros95](https://github.com/chrros95) - Josh Goldberg - Maria Solano [@MariaSolOs](https://github.com/MariaSolOs) - Minyeong Kim [@minyeong981](https://github.com/minyeong981) - SungHyun627 [@SungHyun627](https://github.com/SungHyun627) - Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw) See [GitHub Releases](https://github.com/typescript-eslint/typescript-eslint/releases/tag/v8.55.0) for more information. You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
thisparameter and a default for an attribute of an object parameter #11948Overview
The es tree node has the this parameter in the signature param list, while the ts nodes have an explicit param for that.
So if the thisParameter is detected, the paramIndex is reduced to reflect this difference.