fix(typescript-estree): forbid type-only import with both default and named specifiers by fisker · Pull Request #11930 · typescript-eslint/typescript-eslint

fisker · 2026-01-05T17:51:42Z

PR Checklist

Addresses an existing open issue: fixes #000
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

Throw syntax error for

import type foo, {  } from 'bar';

and

import type foo, { named } from 'bar';

TypeScript playground

… named specifiers

typescript-eslint · 2026-01-05T17:51:46Z

Thanks for the PR, @fisker!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2026-01-05T17:51:48Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`cb124a6`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/695c00a1cb6bba00081f3dcd
😎 Deploy Preview	https://deploy-preview-11930--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (🟢 up 9 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

nx-cloud · 2026-01-05T17:53:03Z

View your CI Pipeline Execution ↗ for commit cb124a6

Command	Status	Duration	Result
`nx run-many -t lint`	✅ Succeeded	3m 6s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	1m 57s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	8s	View ↗
`nx run integration-tests:test`	✅ Succeeded	5s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	2s	View ↗
`nx run types:build`	✅ Succeeded	2s	View ↗
`nx run generate-configs`	✅ Succeeded	8s	View ↗
`nx run-many --target=build --parallel --exclude...`	✅ Succeeded	10s	View ↗
`Additional runs (28)`	✅ Succeeded	...	View ↗

☁️ Nx Cloud last updated this comment at 2026-01-05 18:30:47 UTC

codecov · 2026-01-05T18:31:45Z

Codecov Report

❌ Patch coverage is 30.76923% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.71%. Comparing base (9ddd571) to head (cb124a6).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...kages/typescript-estree/src/check-syntax-errors.ts	30.76%	9 Missing ⚠️

❌ Your patch status has failed because the patch coverage (30.76%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11930      +/-   ##
==========================================
- Coverage   90.73%   90.71%   -0.02%     
==========================================
  Files         527      527              
  Lines       53637    53649      +12     
  Branches     9010     9013       +3     
==========================================
+ Hits        48665    48668       +3     
- Misses       4959     4968       +9     
  Partials       13       13

Flag	Coverage Δ
unittest	`90.71% <30.76%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...kages/typescript-estree/src/check-syntax-errors.ts	`22.46% <30.76%> (+0.07%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JoshuaKGoldberg

ty!

@bradzacher

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.52.0 | 8.53.0 | | npm | @typescript-eslint/parser | 8.52.0 | 8.53.0 | ## [v8.53.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8530-2026-01-12) ##### 🚀 Features - **eslint-plugin:** add rule \[strict-void-return] ([#9707](typescript-eslint/typescript-eslint#9707)) - **eslint-plugin:** \[no-unused-vars] add a fixer to remove unused imports ([#11922](typescript-eslint/typescript-eslint#11922)) ##### 🩹 Fixes - **eslint-plugin:** \[no-useless-default-assignment] fix false positive for parameters corresponding to a rest parameter ([#11916](typescript-eslint/typescript-eslint#11916)) - **eslint-plugin:** replace unclear "`error` typed" with more helpful description ([#11704](typescript-eslint/typescript-eslint#11704)) - **typescript-estree:** forbid invalid `extends` and `implements` in interface declaration ([#11935](typescript-eslint/typescript-eslint#11935)) - **typescript-estree:** forbid invalid class implements ([#11934](typescript-eslint/typescript-eslint#11934)) - **typescript-estree:** forbid type-only import with both default and named specifiers ([#11930](typescript-eslint/typescript-eslint#11930)) ##### ❤️ Thank You - Brad Zacher [@bradzacher](https://github.com/bradzacher) - fisker Cheung [@fisker](https://github.com/fisker) - Josh Goldberg - Josh Goldberg ✨ - Kirk Waiblinger - Niki [@phaux](https://github.com/phaux) - Nikita - SungHyun627 [@SungHyun627](https://github.com/SungHyun627) - Will Harney [@wjhsf](https://github.com/wjhsf) You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.

@bradzacher

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.52.0 | 8.53.0 | | npm | @typescript-eslint/parser | 8.52.0 | 8.53.0 | ## [v8.53.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8530-2026-01-12) ##### 🚀 Features - **eslint-plugin:** add rule \[strict-void-return] ([#9707](typescript-eslint/typescript-eslint#9707)) - **eslint-plugin:** \[no-unused-vars] add a fixer to remove unused imports ([#11922](typescript-eslint/typescript-eslint#11922)) ##### 🩹 Fixes - **eslint-plugin:** \[no-useless-default-assignment] fix false positive for parameters corresponding to a rest parameter ([#11916](typescript-eslint/typescript-eslint#11916)) - **eslint-plugin:** replace unclear "`error` typed" with more helpful description ([#11704](typescript-eslint/typescript-eslint#11704)) - **typescript-estree:** forbid invalid `extends` and `implements` in interface declaration ([#11935](typescript-eslint/typescript-eslint#11935)) - **typescript-estree:** forbid invalid class implements ([#11934](typescript-eslint/typescript-eslint#11934)) - **typescript-estree:** forbid type-only import with both default and named specifiers ([#11930](typescript-eslint/typescript-eslint#11930)) ##### ❤️ Thank You - Brad Zacher [@bradzacher](https://github.com/bradzacher) - fisker Cheung [@fisker](https://github.com/fisker) - Josh Goldberg - Josh Goldberg ✨ - Kirk Waiblinger - Niki [@phaux](https://github.com/phaux) - Nikita - SungHyun627 [@SungHyun627](https://github.com/SungHyun627) - Will Harney [@wjhsf](https://github.com/wjhsf) You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.

fix(typescript-estree): forbid type-only import with both default and…

ef072ac

… named specifiers

Fix eslint plugin

cb124a6

JoshuaKGoldberg approved these changes Jan 5, 2026

View reviewed changes

bradzacher approved these changes Jan 6, 2026

View reviewed changes

bradzacher merged commit a98ec1f into typescript-eslint:main Jan 6, 2026
64 of 65 checks passed

fisker deleted the type-import-default-and-named branch January 6, 2026 05:59

fisker mentioned this pull request Jan 6, 2026

chore: add test for type-only import with both default and namespace specifiers #11933

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(typescript-estree): forbid type-only import with both default and named specifiers#11930

fix(typescript-estree): forbid type-only import with both default and named specifiers#11930
bradzacher merged 2 commits intotypescript-eslint:mainfrom
fisker:type-import-default-and-named

fisker commented Jan 5, 2026

Uh oh!

typescript-eslint bot commented Jan 5, 2026

Uh oh!

netlify bot commented Jan 5, 2026 •

edited

Loading

Uh oh!

nx-cloud bot commented Jan 5, 2026 •

edited

Loading

Uh oh!

codecov bot commented Jan 5, 2026 •

edited

Loading

Uh oh!

JoshuaKGoldberg left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

fisker commented Jan 5, 2026

PR Checklist

Overview

Uh oh!

typescript-eslint bot commented Jan 5, 2026

Uh oh!

netlify bot commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for typescript-eslint ready!

Uh oh!

nx-cloud bot commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlify bot commented Jan 5, 2026 •

edited

Loading

nx-cloud bot commented Jan 5, 2026 •

edited

Loading

codecov bot commented Jan 5, 2026 •

edited

Loading