fix(eslint-plugin): revert "[no-redundant-type-constituents] use assignability checking for redundancy checks" #11812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ignabili…" This reverts commit 2ffb168.
Contributor
|
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit 9a96603
☁️ Nx Cloud last updated this comment at |
JoshuaKGoldberg
changed the title
JoshuaKGoldberg
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11812 +/- ##
==========================================
+ Coverage 90.49% 90.53% +0.04%
==========================================
Files 523 523
Lines 53386 53097 -289
Branches 8919 8838 -81
==========================================
- Hits 48311 48074 -237
+ Misses 5061 5010 -51
+ Partials 14 13 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
JoshuaKGoldberg
deleted the
revert-10744-7742-no-redundant-type-constituents
branch
This was referenced Dec 1, 2025
1 task
jimmy-zhening-luo
added a commit
to jimmy-zhening-luo/linted-defaults
that referenced
this pull request
Dec 2, 2025
…; re-enable the bugged lint rule: eslint-plugin: revert: [no-redundant-type-constituents] use assignability checking for redundancy checks (typescript-eslint/typescript-eslint#10744) (typescript-eslint/typescript-eslint#11812)
jimmy-zhening-luo
added a commit
to jimmy-zhening-luo/linted
that referenced
this pull request
Dec 2, 2025
…; re-enable the bugged lint rule: - eslint-plugin: revert: [no-redundant-type-constituents] use assignability checking for redundancy checks (typescript-eslint/typescript-eslint#10744) (typescript-eslint/typescript-eslint#11812) - chore: update pkg
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #10744.
string | undefinedwithstrickNullChecks: falseshould have an exception #11800