feat(eslint-plugin): use Intl.Segmenter instead of graphemer
#11804
+3
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the PR, @JstnMcBrd! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit 95af122
☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11804 +/- ##
==========================================
- Coverage 90.53% 90.53% -0.01%
==========================================
Files 523 523
Lines 53097 53096 -1
Branches 8838 8838
==========================================
- Hits 48074 48073 -1
Misses 5010 5010
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
JoshuaKGoldberg
added
the
1 approval
fisker
reviewed
Nov 27, 2025
kirkwaiblinger
previously approved these changes
Dec 6, 2025
kirkwaiblinger
dismissed stale reviews from JoshuaKGoldberg and themself
via
95af122
kirkwaiblinger
approved these changes
Dec 6, 2025
1 task
|
I was reading the background and noticed that eslint initializes The change here doesn't specify a locale, which means the runtime's default locale is used (which presumably means the user's locale). For consistency with eslint, it would probably be better to match them. |
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Dec 11, 2025
| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.48.1 | 8.49.0 | | npm | @typescript-eslint/parser | 8.48.1 | 8.49.0 | ## [v8.49.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8490-2025-12-08) ##### 🚀 Features - **eslint-plugin:** use `Intl.Segmenter` instead of `graphemer` ([#11804](typescript-eslint/typescript-eslint#11804)) ##### 🩹 Fixes - **deps:** update dependency prettier to v3.7.2 ([#11820](typescript-eslint/typescript-eslint#11820)) ##### ❤️ Thank You - Justin McBride - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Dec 11, 2025
| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.48.1 | 8.49.0 | | npm | @typescript-eslint/parser | 8.48.1 | 8.49.0 | ## [v8.49.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8490-2025-12-08) ##### 🚀 Features - **eslint-plugin:** use `Intl.Segmenter` instead of `graphemer` ([#11804](typescript-eslint/typescript-eslint#11804)) ##### 🩹 Fixes - **deps:** update dependency prettier to v3.7.2 ([#11820](typescript-eslint/typescript-eslint#11820)) ##### ❤️ Thank You - Justin McBride - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Dec 13, 2025
| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.48.1 | 8.49.0 | | npm | @typescript-eslint/parser | 8.48.1 | 8.49.0 | ## [v8.49.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8490-2025-12-08) ##### 🚀 Features - **eslint-plugin:** use `Intl.Segmenter` instead of `graphemer` ([#11804](typescript-eslint/typescript-eslint#11804)) ##### 🩹 Fixes - **deps:** update dependency prettier to v3.7.2 ([#11820](typescript-eslint/typescript-eslint#11820)) ##### ❤️ Thank You - Justin McBride - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Intl.Segmenterinstead ofgraphemer#11803Overview
See the description of #11803 for the backstory.