Skip to content

chore: remove SKIP_AST_SPEC_REBUILD internally #11783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JoshuaKGoldberg merged 2 commits into from
Nov 24, 2025
Merged

chore: remove SKIP_AST_SPEC_REBUILD internally #11783

JoshuaKGoldberg merged 2 commits into from
Nov 24, 2025

Conversation

@JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Nov 24, 2025

PR Checklist

Overview

Split out of the changes @JamesHenry pushed to #11760. Therefore:

Co-authored-by: @JamesHenry

💖

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Nov 24, 2025

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Nov 24, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit c6e76a3
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/692459a057cba20008469a99
😎 Deploy Preview https://deploy-preview-11783--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (🟢 up 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link

nx-cloud bot commented Nov 24, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit c6e76a3

Command Status Duration Result
nx run-many -t lint ✅ Succeeded 3m 17s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 12s View ↗
nx run types:build ✅ Succeeded 2s View ↗
nx run-many -t typecheck ✅ Succeeded 1m 56s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 21s View ↗
nx run generate-configs ✅ Succeeded 8s View ↗
nx run integration-tests:test ✅ Succeeded 5s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 11s View ↗
Additional runs (29) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-11-24 13:28:23 UTC

@JoshuaKGoldberg JoshuaKGoldberg merged commit 78858ee into typescript-eslint:main Nov 24, 2025
63 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

@bradzacher bradzacher Awaiting requested review from bradzacher bradzacher is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Repo: Can't build packages when new property added to Node

2 participants

@JoshuaKGoldberg @JamesHenry