fix(eslint-plugin): replace unclear "`error` typed" with more helpful description by wjhsf · Pull Request #11704 · typescript-eslint/typescript-eslint

wjhsf · 2025-10-17T15:24:18Z

PR Checklist

Addresses an existing open issue: fixes Bug: [no-unsafe-call] Unclear message "Unsafe call of an error type typed value" (especially in JSDoc) #9591
That issue was marked as accepting prs
~~Steps in Contributing were taken~~

Overview

As described in #9591, the error message "Unsafe call of a(n) error type typed value". Namely, what is "an error type typed value"? It's unclear to anyone who does not know that TypeScript has a special flavor of any for types that could not be resolved. (Probably just about everyone who doesn't work on TypeScript tooling.)

This PR aims to provide clarity by changing "error typed" to "unresolved due to error", resulting in error messages like "Unsafe call of a(n) unresolved due to error typed value". Not the most natural phrasing, and it would probably be better to use a distinct error message, but my goal was to make a minimal change and not have to go stomping through the code to figure things out. 😅

typescript-eslint · 2025-10-17T15:24:21Z

Thanks for the PR, @wjhsf!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2025-10-17T15:24:23Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`ddad6d8`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/695e86b7ec9c92000823d031
😎 Deploy Preview	https://deploy-preview-11704--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 98 (🟢 up 8 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

nx-cloud · 2025-10-17T15:26:06Z

View your CI Pipeline Execution ↗ for commit ddad6d8

Command	Status	Duration	Result
`nx run-many -t lint`	✅ Succeeded	3m 14s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	2m 3s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	2s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	3s	View ↗
`nx run types:build`	✅ Succeeded	2s	View ↗
`nx run integration-tests:test`	✅ Succeeded	3s	View ↗
`nx run generate-configs`	✅ Succeeded	6s	View ↗
`nx run-many --target=build --parallel --exclude...`	✅ Succeeded	5s	View ↗
`Additional runs (28)`	✅ Succeeded	...	View ↗

☁️ Nx Cloud last updated this comment at 2026-01-07 16:27:58 UTC

codecov · 2025-10-17T15:36:59Z

Codecov Report

❌ Patch coverage is 96.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.72%. Comparing base (3ac7735) to head (ddad6d8).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...eslint-plugin/src/rules/no-unsafe-member-access.ts	93.10%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11704      +/-   ##
==========================================
- Coverage   90.73%   90.72%   -0.01%     
==========================================
  Files         527      527              
  Lines       53659    53678      +19     
  Branches     9021     9026       +5     
==========================================
+ Hits        48685    48702      +17     
- Misses       4961     4963       +2     
  Partials       13       13

Flag	Coverage Δ
unittest	`90.72% <96.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
packages/eslint-plugin/src/rules/no-unsafe-call.ts	`97.22% <100.00%> (+0.19%)`	⬆️
...eslint-plugin/src/rules/no-unsafe-member-access.ts	`98.63% <93.10%> (-1.37%)`	⬇️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JoshuaKGoldberg

🙌 time to bikeshed! 🙌

packages/eslint-plugin/src/rules/no-unsafe-call.ts

…fe-call`

…fe-member-access`

packages/eslint-plugin/src/rules/no-unsafe-call.ts

JoshuaKGoldberg

I like the direction this is taking, +1! I think the only blocker for me is the removing the second line of the this messages - WDYT?

packages/eslint-plugin/src/rules/no-unsafe-call.ts

…e}}` The article is now included in the type's text.

JoshuaKGoldberg

🤩 This looks great to me, thank you for all the iterations! Just pinging @typescript-eslint/triage-team to see if anybody else wants to provide input.

I'll also note there are some CI failures. If you have time to clean those up, that'd be nice. But we can always step in before merging - I know this PR has had a lot of back-and-forth.

packages/eslint-plugin/src/rules/no-unsafe-call.ts

JoshuaKGoldberg

Looking good, thanks! 🙌

@bradzacher

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.52.0 | 8.53.0 | | npm | @typescript-eslint/parser | 8.52.0 | 8.53.0 | ## [v8.53.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8530-2026-01-12) ##### 🚀 Features - **eslint-plugin:** add rule \[strict-void-return] ([#9707](typescript-eslint/typescript-eslint#9707)) - **eslint-plugin:** \[no-unused-vars] add a fixer to remove unused imports ([#11922](typescript-eslint/typescript-eslint#11922)) ##### 🩹 Fixes - **eslint-plugin:** \[no-useless-default-assignment] fix false positive for parameters corresponding to a rest parameter ([#11916](typescript-eslint/typescript-eslint#11916)) - **eslint-plugin:** replace unclear "`error` typed" with more helpful description ([#11704](typescript-eslint/typescript-eslint#11704)) - **typescript-estree:** forbid invalid `extends` and `implements` in interface declaration ([#11935](typescript-eslint/typescript-eslint#11935)) - **typescript-estree:** forbid invalid class implements ([#11934](typescript-eslint/typescript-eslint#11934)) - **typescript-estree:** forbid type-only import with both default and named specifiers ([#11930](typescript-eslint/typescript-eslint#11930)) ##### ❤️ Thank You - Brad Zacher [@bradzacher](https://github.com/bradzacher) - fisker Cheung [@fisker](https://github.com/fisker) - Josh Goldberg - Josh Goldberg ✨ - Kirk Waiblinger - Niki [@phaux](https://github.com/phaux) - Nikita - SungHyun627 [@SungHyun627](https://github.com/SungHyun627) - Will Harney [@wjhsf](https://github.com/wjhsf) You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.

@bradzacher

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.52.0 | 8.53.0 | | npm | @typescript-eslint/parser | 8.52.0 | 8.53.0 | ## [v8.53.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8530-2026-01-12) ##### 🚀 Features - **eslint-plugin:** add rule \[strict-void-return] ([#9707](typescript-eslint/typescript-eslint#9707)) - **eslint-plugin:** \[no-unused-vars] add a fixer to remove unused imports ([#11922](typescript-eslint/typescript-eslint#11922)) ##### 🩹 Fixes - **eslint-plugin:** \[no-useless-default-assignment] fix false positive for parameters corresponding to a rest parameter ([#11916](typescript-eslint/typescript-eslint#11916)) - **eslint-plugin:** replace unclear "`error` typed" with more helpful description ([#11704](typescript-eslint/typescript-eslint#11704)) - **typescript-estree:** forbid invalid `extends` and `implements` in interface declaration ([#11935](typescript-eslint/typescript-eslint#11935)) - **typescript-estree:** forbid invalid class implements ([#11934](typescript-eslint/typescript-eslint#11934)) - **typescript-estree:** forbid type-only import with both default and named specifiers ([#11930](typescript-eslint/typescript-eslint#11930)) ##### ❤️ Thank You - Brad Zacher [@bradzacher](https://github.com/bradzacher) - fisker Cheung [@fisker](https://github.com/fisker) - Josh Goldberg - Josh Goldberg ✨ - Kirk Waiblinger - Niki [@phaux](https://github.com/phaux) - Nikita - SungHyun627 [@SungHyun627](https://github.com/SungHyun627) - Will Harney [@wjhsf](https://github.com/wjhsf) You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.

replace unclear "error typed" with more helpful description

c3217ae

wjhsf changed the title ~~replace unclear "error typed" with more helpful description~~ fix(no-unsafe-call): replace unclear "error typed" with more helpful description Oct 17, 2025

Merge branch 'main' into wjh/avoid-unclear-error-typed

9f3e331

wjhsf changed the title ~~fix(no-unsafe-call): replace unclear "error typed" with more helpful description~~ fix(eslint-plugin): replace unclear "error typed" with more helpful description Oct 31, 2025

JoshuaKGoldberg requested changes Nov 3, 2025

View reviewed changes

packages/eslint-plugin/src/rules/no-unsafe-call.ts Outdated Show resolved Hide resolved

JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Nov 3, 2025

wjhsf and others added 5 commits December 23, 2025 12:07

Merge branch 'main' into wjh/avoid-unclear-error-typed

d4164a7

feat(eslint-plugin): clarify "error typed" error message for `no-unsa…

6b5ae73

…fe-call`

feat(eslint-plugin): change "a(n)" to variable {{article}}

b2df383

feat(eslint-plugin): clarify "error typed" error message for `no-unsa…

6322c9b

…fe-member-access`

Merge branch 'main' into wjh/avoid-unclear-error-typed

b8db09b

wjhsf commented Dec 23, 2025

View reviewed changes

packages/eslint-plugin/src/rules/no-unsafe-call.ts Outdated Show resolved Hide resolved

packages/eslint-plugin/src/rules/no-unsafe-call.ts Show resolved Hide resolved

JoshuaKGoldberg requested changes Dec 27, 2025

View reviewed changes

packages/eslint-plugin/src/rules/no-unsafe-call.ts Outdated Show resolved Hide resolved

packages/eslint-plugin/src/rules/no-unsafe-call.ts Outdated Show resolved Hide resolved

wjhsf added 3 commits January 5, 2026 10:54

Merge branch 'main' into wjh/avoid-unclear-error-typed

5281ba6

fix(eslint-plugin): remove misleading guidance from error message

07a52fa

refactor(eslint-plugin): change {{article}} {{type}} to just `{{typ…

8b87a5d

…e}}` The article is now included in the type's text.

wjhsf requested a review from JoshuaKGoldberg January 5, 2026 15:57

github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Jan 5, 2026

JoshuaKGoldberg previously approved these changes Jan 5, 2026

View reviewed changes

JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jan 5, 2026

bradzacher reviewed Jan 6, 2026

View reviewed changes

packages/eslint-plugin/src/rules/no-unsafe-call.ts Outdated Show resolved Hide resolved

Apply suggestion from @bradzacher

e000bf0

bradzacher dismissed JoshuaKGoldberg’s stale review via e000bf0 January 6, 2026 22:51

bradzacher previously approved these changes Jan 6, 2026

View reviewed changes

bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Jan 6, 2026

test(eslint-plugin): update tests to new article format

b7a7970

wjhsf dismissed bradzacher’s stale review via b7a7970 January 7, 2026 16:15

Merge branch 'main' into wjh/avoid-unclear-error-typed

ddad6d8

wjhsf requested review from JoshuaKGoldberg and bradzacher January 7, 2026 16:16

github-actions bot removed 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge awaiting response Issues waiting for a reply from the OP or another party labels Jan 7, 2026

JoshuaKGoldberg approved these changes Jan 8, 2026

View reviewed changes

JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jan 8, 2026

bradzacher approved these changes Jan 9, 2026

View reviewed changes

bradzacher merged commit c4d5a56 into typescript-eslint:main Jan 9, 2026
68 checks passed

chrisbbreuer mentioned this pull request Jan 12, 2026

chore(deps): update all non-major dependencies stacksjs/eslint-plugin#67

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(eslint-plugin): replace unclear "`error` typed" with more helpful description#11704

fix(eslint-plugin): replace unclear "`error` typed" with more helpful description#11704
bradzacher merged 13 commits intotypescript-eslint:mainfrom
wjhsf:wjh/avoid-unclear-error-typed

wjhsf commented Oct 17, 2025

Uh oh!

typescript-eslint bot commented Oct 17, 2025

Uh oh!

netlify bot commented Oct 17, 2025 •

edited

Loading

Uh oh!

nx-cloud bot commented Oct 17, 2025 •

edited

Loading

Uh oh!

codecov bot commented Oct 17, 2025 •

edited

Loading

Uh oh!

JoshuaKGoldberg left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Uh oh!

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

wjhsf commented Oct 17, 2025

PR Checklist

Overview

Uh oh!

typescript-eslint bot commented Oct 17, 2025

Uh oh!

netlify bot commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for typescript-eslint ready!

Uh oh!

nx-cloud bot commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlify bot commented Oct 17, 2025 •

edited

Loading

nx-cloud bot commented Oct 17, 2025 •

edited

Loading

codecov bot commented Oct 17, 2025 •

edited

Loading