Skip to content

docs(eslint-plugin): [prefer-optional-chain] remove unnecessary docs chainings #11638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JoshuaKGoldberg merged 2 commits into from
Oct 3, 2025
Merged

docs(eslint-plugin): [prefer-optional-chain] remove unnecessary docs chainings #11638

JoshuaKGoldberg merged 2 commits into from
Oct 3, 2025

Conversation

@JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Sep 26, 2025

PR Checklist

Overview

Since only the foo.a part is relevant, I removed the rest.

💖

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Sep 26, 2025

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Sep 26, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 60f8237
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/68daa6f2c359ec0008751ae7
😎 Deploy Preview https://deploy-preview-11638--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (🟢 up 5 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link

nx-cloud bot commented Sep 26, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 60f8237

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 5s View ↗
nx run-many -t lint ✅ Succeeded 3m 13s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 5s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 11s View ↗
nx run integration-tests:test ✅ Succeeded 6s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 2s View ↗
nx run generate-configs ✅ Succeeded 13s View ↗
nx run types:build ✅ Succeeded 9s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-09-29 15:49:24 UTC

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review September 26, 2025 14:22
bradzacher
bradzacher previously approved these changes Sep 26, 2025
View reviewed changes
@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Sep 26, 2025
@github-actions github-actions bot removed the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Sep 29, 2025
@codecov
Copy link

codecov bot commented Sep 29, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.93%. Comparing base (9fd1cc6) to head (60f8237).
⚠️ Report is 29 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11638   +/-   ##
=======================================
  Coverage   90.93%   90.93%           
=======================================
  Files         506      506           
  Lines       51370    51397   +27     
  Branches     8476     8481    +5     
=======================================
+ Hits        46711    46738   +27     
  Misses       4646     4646           
  Partials       13       13
Flag Coverage Δ
unittest 90.93% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Sep 29, 2025
@JoshuaKGoldberg JoshuaKGoldberg merged commit 0ee9352 into typescript-eslint:main Oct 3, 2025
63 of 64 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the prefer-optional-chain-foo-a-docs branch October 3, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

@bradzacher bradzacher bradzacher left review comments

Assignees

No one assigned

Labels

1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Docs: [prefer-optional-chain] fix confusing example of chained strict nullish checks

3 participants

@JoshuaKGoldberg @bradzacher @kirkwaiblinger