feat(eslint-plugin-internal): [no-dynamic-tests] new internal Lint rule to ban dynamic syntax in generating tests #11323

nayounsang · 2025-06-20T12:40:17Z

PR Checklist

Addresses an existing open issue: fixes Repo: Lint rule to ban dynamic syntax in generating tests #11052
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

no-dynamic-tests

Ban these:

{
  invalid: {...spread},
  valid: identifier,
  invalid: bi + nary,
  valid: callExp(),
  invalid: `${templateLiteralWithDynamic()}`,
  valid: obj.member,
  invalid: condition? foo : bar,
}

For test case object, It validate these keys recursively: code, error.
No checks are performed on other keys.

Applied the rules to the test file in eslint-plugin & eslint-plugin-internal. Bulk suppression feature was applied.
Create the script to update suppression.

typescript-eslint · 2025-06-20T12:40:21Z

Thanks for the PR, @nayounsang!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2025-06-20T12:40:22Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`c973039`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/68e3c39af134b500087b80f1
😎 Deploy Preview	https://deploy-preview-11323--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 81 (🟢 up 3 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

nx-cloud · 2025-06-20T12:41:52Z

View your CI Pipeline Execution ↗ for commit c973039

Command	Status	Duration	Result
`nx run-many -t lint`	✅ Succeeded	3m 22s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	2m 8s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	4s	View ↗
`nx test eslint-plugin --coverage=false`	✅ Succeeded	4s	View ↗
`nx run types:build`	✅ Succeeded	5s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	1s	View ↗
`nx run integration-tests:test`	✅ Succeeded	3s	View ↗
`nx run generate-configs`	✅ Succeeded	6s	View ↗
`Additional runs (29)`	✅ Succeeded	...	View ↗

☁️ Nx Cloud last updated this comment at 2025-10-06 13:33:46 UTC

codecov · 2025-06-20T12:46:36Z

Codecov Report

❌ Patch coverage is 93.60000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.69%. Comparing base (02e0278) to head (c973039).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...lint-plugin-internal/src/rules/no-dynamic-tests.ts	93.60%	8 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##             main   #11323    +/-   ##
========================================
  Coverage   90.68%   90.69%            
========================================
  Files         516      517     +1     
  Lines       52051    52176   +125     
  Branches     8598     8632    +34     
========================================
+ Hits        47202    47319   +117     
- Misses       4835     4843     +8     
  Partials       14       14

Flag	Coverage Δ
unittest	`90.69% <93.60%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...lint-plugin-internal/src/rules/no-dynamic-tests.ts	`93.60% <93.60%> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JoshuaKGoldberg

LGTM, thanks! Only the one request for an added test is blocking IMO. Everything else is nitpicks that can be ignored if you don't like them. 🙂

packages/eslint-plugin-internal/src/rules/no-dynamic-tests.ts

packages/eslint-plugin-internal/tests/rules/no-dynamic-tests.test.ts

JoshuaKGoldberg

🔥 thanks!

kirkwaiblinger

I think that if we intend to use this ever, we should enable it already now for all the files that don't currently have violations. (Maybe even this is a good chance for us to try out the eslint bulk suppressions feature)?

Also, please do enable the rule on the codebase and have a look at the reports to see whether they make sense and would make sense to a contributor.

Thanks!

packages/eslint-plugin-internal/src/rules/no-dynamic-tests.ts

package.json

…pt-eslint into dynamic-lint

package.json

eslint.config.mjs

JoshuaKGoldberg

LGTM. +1 to @kirkwaiblinger's suggestions on improving the reporting of the rule. I'll want to hear from Kirk before merging too.

package.json

kirkwaiblinger

(see comment)

JoshuaKGoldberg

Looks great to me, thanks for jumping on this! 🙌

I'll note that the rule isn't completely covered by unit tests. But since it's internal & specific to this repo (for now?) I think that's fine.

nayounsang added 3 commits June 20, 2025 21:35

test: add test cases

c1bc74d

feat: internal no-dynamic-tests rule

8a2f933

feat: export rule

e83a77d

nayounsang changed the title ~~feat(eslint-plugin-internal) : Lint rule to ban dynamic syntax in generating tests~~ feat(eslint-plugin-internal): Lint rule to ban dynamic syntax in generating tests Jun 20, 2025

nayounsang changed the title ~~feat(eslint-plugin-internal): Lint rule to ban dynamic syntax in generating tests~~ feat(eslint-plugin-internal): [no-dynamic-tests] new internal Lint rule to ban dynamic syntax in generating tests Jun 20, 2025

fix: more suitable conditions

5a2d020

JoshuaKGoldberg requested changes Jun 23, 2025

View reviewed changes

packages/eslint-plugin-internal/src/rules/no-dynamic-tests.ts Outdated Show resolved Hide resolved

packages/eslint-plugin-internal/src/rules/no-dynamic-tests.ts Outdated Show resolved Hide resolved

packages/eslint-plugin-internal/tests/rules/no-dynamic-tests.test.ts Show resolved Hide resolved

JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Jun 23, 2025

nayounsang added 2 commits June 24, 2025 16:50

refactor: remove cmts

6a29248

test: add valid tc for noFormat

987cd78

JoshuaKGoldberg previously approved these changes Jun 24, 2025

View reviewed changes

JoshuaKGoldberg added 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge and removed awaiting response Issues waiting for a reply from the OP or another party labels Jun 24, 2025

kirkwaiblinger requested changes Jul 6, 2025

View reviewed changes

packages/eslint-plugin-internal/src/rules/no-dynamic-tests.ts Outdated Show resolved Hide resolved

packages/eslint-plugin-internal/src/rules/no-dynamic-tests.ts Show resolved Hide resolved

packages/eslint-plugin-internal/src/rules/no-dynamic-tests.ts Show resolved Hide resolved

kirkwaiblinger added awaiting response Issues waiting for a reply from the OP or another party and removed 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labels Jul 6, 2025

nayounsang and others added 3 commits July 7, 2025 22:44

Merge branch 'main' into dynamic-lint

47396ab

fix: should allow noFormat tag

0037283

fix: narrow report node

9c3ebce

nayounsang dismissed JoshuaKGoldberg’s stale review via 9c3ebce July 7, 2025 14:26

nayounsang added 3 commits July 7, 2025 23:39

test: add nested dynamic test

ac6726f

fix: fix err column

dc8b568

feat: enable object dynamic value

f81a9de

This comment was marked as resolved.

Sign in to view

nayounsang and others added 2 commits July 9, 2025 21:31

Merge branch 'main' into dynamic-lint

d684378

feat: key to validate

ba32259

kirkwaiblinger reviewed Jul 14, 2025

View reviewed changes

package.json Outdated Show resolved Hide resolved

nayounsang and others added 3 commits July 16, 2025 16:22

Merge branch 'main' into dynamic-lint

a3e8ff2

fix: revert weird script

69c8818

Merge branch 'dynamic-lint' of https://github.com/nayounsang/typescri…

e668354

…pt-eslint into dynamic-lint

nayounsang commented Jul 20, 2025

View reviewed changes

package.json Outdated Show resolved Hide resolved

Merge branch 'main' into dynamic-lint

d763c7a

nayounsang commented Jul 20, 2025

View reviewed changes

eslint.config.mjs Show resolved Hide resolved

nayounsang requested a review from kirkwaiblinger July 20, 2025 11:49

Merge branch 'main' into dynamic-lint

2ef03e1

JoshuaKGoldberg previously approved these changes Sep 15, 2025

View reviewed changes

JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Sep 15, 2025

kirkwaiblinger reviewed Sep 16, 2025

View reviewed changes

package.json Show resolved Hide resolved

kirkwaiblinger requested changes Sep 16, 2025

View reviewed changes

JoshuaKGoldberg removed the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Sep 16, 2025

chore: revert lock and package json

34d4783

nayounsang dismissed JoshuaKGoldberg’s stale review via 34d4783 September 19, 2025 13:31

Merge branch 'main' into dynamic-lint

0da18c5

nayounsang requested a review from kirkwaiblinger September 19, 2025 13:45

JoshuaKGoldberg previously approved these changes Oct 3, 2025

View reviewed changes

JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Oct 3, 2025

JoshuaKGoldberg requested review from kirkwaiblinger and removed request for kirkwaiblinger October 3, 2025 12:06

github-actions bot removed the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Oct 3, 2025

Merge branch 'main'

47ba275

JoshuaKGoldberg dismissed their stale review via 47ba275 October 6, 2025 12:50

JoshuaKGoldberg added 2 commits October 6, 2025 09:02

fix typecheck

74dd89a

Merge branch 'main' into dynamic-lint

c973039

JoshuaKGoldberg merged commit aea862d into typescript-eslint:main Oct 6, 2025
68 checks passed

chrisbbreuer mentioned this pull request Oct 6, 2025

chore(deps): update all non-major dependencies stacksjs/eslint-plugin#67

Open

1 task

fossabot bot mentioned this pull request Oct 9, 2025

Bump @typescript-eslint/eslint-plugin from 8.44.1 to 8.46.0 fossas/fossa-action#220

Merged

Uh oh!

feat(eslint-plugin-internal): [no-dynamic-tests] new internal Lint rule to ban dynamic syntax in generating tests #11323

feat(eslint-plugin-internal): [no-dynamic-tests] new internal Lint rule to ban dynamic syntax in generating tests #11323

Conversation

nayounsang commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslint bot commented Jun 20, 2025

Uh oh!

netlify bot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for typescript-eslint ready!

Uh oh!

nx-cloud bot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

kirkwaiblinger left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kirkwaiblinger left a comment

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nayounsang commented Jun 20, 2025 •

edited

Loading

netlify bot commented Jun 20, 2025 •

edited

Loading

nx-cloud bot commented Jun 20, 2025 •

edited

Loading

codecov bot commented Jun 20, 2025 •

edited

Loading