Skip to content

fix(typescript-estree): correct semver check range#1109

Merged
bradzacher merged 1 commit intomasterfrom
bz-patch-1
Oct 19, 2019
Merged

fix(typescript-estree): correct semver check range#1109
bradzacher merged 1 commit intomasterfrom
bz-patch-1

Conversation

@bradzacher
Copy link
Copy Markdown
Member

@bradzacher bradzacher commented Oct 19, 2019

It wasn't matching 3.6.4 as valid because I missed the pipe.

@typescript-eslint
Copy link
Copy Markdown
Contributor

typescript-eslint Bot commented Oct 19, 2019

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher mentioned this pull request Oct 19, 2019
Closed
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 19, 2019

Codecov Report

Merging #1109 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #1109   +/-   ##
=======================================
  Coverage   94.09%   94.09%           
=======================================
  Files         120      120           
  Lines        5200     5200           
  Branches     1442     1442           
=======================================
  Hits         4893     4893           
  Misses        176      176           
  Partials      131      131
Impacted Files Coverage Δ
packages/typescript-estree/src/parser.ts 95.57% <100%> (ø) ⬆️

@bradzacher bradzacher merged commit 2fc9bd2 into master Oct 19, 2019
@bradzacher bradzacher deleted the bz-patch-1 branch October 19, 2019 22:59
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bradzacher @JamesHenry