fix(typescript-estree): handle running out of fs watchers#1088
Merged
JamesHenry merged 2 commits intomasterfrom Oct 16, 2019
Merged
fix(typescript-estree): handle running out of fs watchers#1088JamesHenry merged 2 commits intomasterfrom
JamesHenry merged 2 commits intomasterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #1088 +/- ##
=========================================
- Coverage 94.06% 94% -0.06%
=========================================
Files 115 115
Lines 5086 5107 +21
Branches 1423 1426 +3
=========================================
+ Hits 4784 4801 +17
- Misses 174 177 +3
- Partials 128 129 +1
|
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1080
I followed typescript's lead here, and fall back to polling if
chokidarthrows an error when attempting to use fs watchers.I also added support for reusing watchers, to attempt to conserve resources, and reduce the total number of watchers that we setup.
I also decided it was time to setup some logging to help with debugging.
The logging can be shown via
DEBUG=typescript-eslint:* yarn lint