Skip to content

chore: fix failing integration tests on the main branch #10870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JoshuaKGoldberg merged 4 commits into from
Feb 24, 2025
Merged

chore: fix failing integration tests on the main branch #10870

JoshuaKGoldberg merged 4 commits into from
Feb 24, 2025
+0 −2

Conversation

@ronami
Copy link
Member

@ronami ronami commented Feb 22, 2025 •
edited
Loading

PR Checklist

Overview

The main branch's integration tests are failing consistently. I think this is related to a recent release of @types/eslint__js.

The package itself seems to be deprecated and isn't necessary anymore, see:

I'm not sure why exactly, but it seems that the version currently released for @types/eslint__js as the latest tag has no index.d.ts file. I think this is causing the integration tests (that check that types are valid) to fail with: Cannot find type definition file for 'eslint__js'. (even if the file checked is empty).

Installing the latest version of @types/eslint__js and type checking an empty file seems to error on the above.

Should I open an issue about this? Having an empty index.d.ts can help in cases it's accidentally installed (unless this is intended since it's now deprecated).

@netlify
Copy link

netlify bot commented Feb 22, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 9d8e69e
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67ba55d73a3bea00080126e0
😎 Deploy Preview https://deploy-preview-10870--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 79 (🟢 up 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@ronami ronami changed the title chore(tests): fix failing integration tests on the main branch chore(test): fix failing integration tests on the main branch Feb 22, 2025
@nx-cloud
Copy link

nx-cloud bot commented Feb 22, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 9d8e69e.

Command Status Duration Result
nx run-many --target=build --exclude website --... ✅ Succeeded 1s View ↗
nx run-many --target=clean ✅ Succeeded 10s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-22 23:03:14 UTC

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Feb 22, 2025

Thanks for the PR, @ronami!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@ronami ronami changed the title chore(test): fix failing integration tests on the main branch test(integration-tests): fix failing integration tests on the main branch Feb 22, 2025
@ronami ronami changed the title test(integration-tests): fix failing integration tests on the main branch chore: fix failing integration tests on the main branch Feb 22, 2025
@ronami ronami marked this pull request as ready for review February 22, 2025 22:47
@OlivierZal
Copy link
Contributor

OlivierZal commented Feb 22, 2025

Thanks @ronami!

@OlivierZal OlivierZal mentioned this pull request Feb 22, 2025
Merged
3 tasks
@OlivierZal OlivierZal mentioned this pull request Feb 22, 2025
Merged
3 tasks
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤕

@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Feb 24, 2025

Should I open an issue about this?

Probably a good idea, yeah. Even if it's correct as-is, it's good to have SEO friendly questions about it.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 67ab379 into typescript-eslint:main Feb 24, 2025
90 of 91 checks passed
@ronami ronami deleted the fix-main-branch-failing branch February 24, 2025 17:50
@kirkwaiblinger kirkwaiblinger mentioned this pull request Mar 2, 2025
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ronami @OlivierZal @JoshuaKGoldberg