Skip to content

fix(typescript-estree): parsing error for vue sfc#1083

Merged
bradzacher merged 2 commits intotypescript-eslint:masterfrom
yoyo930021:fix-vue-sfc
Oct 20, 2019
Merged

fix(typescript-estree): parsing error for vue sfc#1083
bradzacher merged 2 commits intotypescript-eslint:masterfrom
yoyo930021:fix-vue-sfc

Conversation

@yoyo930021
Copy link
Copy Markdown
Contributor

@yoyo930021 yoyo930021 commented Oct 15, 2019 •
edited
Loading

@typescript-eslint
Copy link
Copy Markdown
Contributor

typescript-eslint Bot commented Oct 15, 2019

Thanks for the PR, @yoyo930021!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@yoyo930021 yoyo930021 force-pushed the fix-vue-sfc branch 2 times, most recently from 1993d1f to 97ae5e7 Compare October 15, 2019 09:52
@yoyo930021
Copy link
Copy Markdown
Contributor Author

yoyo930021 commented Oct 15, 2019

Reason:
The TypeScript program will read all the files and include the .vue files.
The .vue files were read include no-ts part in the TypeScript program.

bradzacher
bradzacher requested changes Oct 15, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests for this?
It's hard to verify that this will fix anything without them.
Additionally we want to ensure that we don't accidentally break this in future, which we can't do without tests.

@bradzacher bradzacher added the bug Something isn't working label Oct 15, 2019
@yoyo930021
Copy link
Copy Markdown
Contributor Author

yoyo930021 commented Oct 16, 2019 •
edited
Loading

Could you please add tests for this?
It's hard to verify that this will fix anything without them.
Additionally we want to ensure that we don't accidentally break this in future, which we can't do without tests.

I finished.

No pass test snap:
test.js.snap.log

@yoyo930021 yoyo930021 requested a review from bradzacher October 17, 2019 04:08
@yoyo930021 yoyo930021 mentioned this pull request Oct 18, 2019
Closed
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 18, 2019 •
edited
Loading

Codecov Report

Merging #1083 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #1083   +/-   ##
=======================================
  Coverage   94.09%   94.09%           
=======================================
  Files         120      120           
  Lines        5200     5200           
  Branches     1442     1442           
=======================================
  Hits         4893     4893           
  Misses        176      176           
  Partials      131      131
Impacted Files Coverage Δ
...pt-estree/src/create-program/createWatchProgram.ts 92.99% <100%> (ø) ⬆️

@yoyo930021
Copy link
Copy Markdown
Contributor Author

yoyo930021 commented Oct 18, 2019

@bradzacher
This PR will update file content in Typescript program when lint this file.

Need to update file content when checking about file content isn't equal linting code?

bradzacher
bradzacher approved these changes Oct 20, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.
I just rebased this on top of master, and fixed the conflicts.
I'll merge this when it passes

@bradzacher bradzacher merged commit 7a8cce6 into typescript-eslint:master Oct 20, 2019
@Mister-Hope Mister-Hope mentioned this pull request Oct 22, 2019
Closed
@IlCallo IlCallo mentioned this pull request Oct 22, 2019
Closed
This was referenced Oct 23, 2019
Closed
Closed
@GordonBlahut GordonBlahut mentioned this pull request Oct 23, 2019
Closed
@yoyo930021 yoyo930021 deleted the fix-vue-sfc branch November 6, 2019 09:26
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

False positives when using with Vue SFC

2 participants

@yoyo930021 @bradzacher