chore(visitor-keys): migrate from `jest` to `vitest` #10773

aryaemami59 · 2025-02-04T07:54:06Z

PR Checklist

Is part of ongoing attempt at resolving Repo: Move from Jest to Vitest #7112.
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

typescript-eslint · 2025-02-04T07:54:09Z

Thanks for the PR, @aryaemami59!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2025-02-04T07:54:22Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`e7ad033`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/67f4280f18531200089b7b90
😎 Deploy Preview	https://deploy-preview-10773--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 92 (🟢 up 4 from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

nx-cloud · 2025-02-04T07:55:33Z

View your CI Pipeline Execution ↗ for commit e7ad033.

Command	Status	Duration	Result
`nx run-many --target=build --exclude website --...`	✅ Succeeded	4s	View ↗
`nx run-many --target=clean`	✅ Succeeded	10s	View ↗

☁️ Nx Cloud last updated this comment at 2025-04-07 20:51:21 UTC

codecov · 2025-02-04T08:32:26Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.12%. Comparing base (ef7e6de) to head (e7ad033).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10773      +/-   ##
==========================================
+ Coverage   88.03%   88.12%   +0.09%     
==========================================
  Files         470      470              
  Lines       16801    16929     +128     
  Branches     4745     4746       +1     
==========================================
+ Hits        14790    14919     +129     
+ Misses       1664     1663       -1     
  Partials      347      347

Flag	Coverage Δ
unittest	`88.12% <ø> (+0.09%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JoshuaKGoldberg · 2025-02-25T12:54:02Z

Marking as blocked on #10582. We'd like to normalize test scripts & coverage calculations before making the jump in individual packages.

…t-eslint into chore/visitor-keys-vitest-migration

packages/visitor-keys/tests/visitor-keys.test.ts

43081j · 2025-04-01T08:00:20Z

this one looks good to me 👍

…t-eslint into chore/visitor-keys-vitest-migration

aryaemami59 · 2025-04-07T11:58:07Z

knip.ts

+
+  vite: false,
+


It doesn't change the result but since we have vite in our devDependencies, the vite plugin for knip still infers that that this is a vite project which is not accurate, on top of that knip has to do a little bit less work which makes things a teeny tiny bit faster.

…t-eslint into chore/visitor-keys-vitest-migration

JoshuaKGoldberg

LGTM, thanks! Just the one comment/question on the vitest property and I think we're good to merge. 🚀

packages/visitor-keys/tests/visitor-keys.test.ts

…t-eslint into chore/visitor-keys-vitest-migration

aryaemami59 force-pushed the chore/visitor-keys-vitest-migration branch 18 times, most recently from 81bf89a to 0620b48 Compare February 10, 2025 17:55

aryaemami59 force-pushed the chore/visitor-keys-vitest-migration branch 6 times, most recently from 62a825e to e14025d Compare February 15, 2025 12:23

JoshuaKGoldberg added the blocked by another PR PRs which are ready to go but waiting on another PR label Feb 25, 2025

aryaemami59 added 4 commits March 12, 2025 18:54

Merge branch 'main' of https://github.com/typescript-eslint/typescrip…

c05f436

…t-eslint into chore/visitor-keys-vitest-migration

Merge branch 'main' of https://github.com/typescript-eslint/typescrip…

3dee53e

…t-eslint into chore/visitor-keys-vitest-migration

Update vite to version 6.2.2

6324278

Fix typecheck task

008698e

aryaemami59 force-pushed the chore/visitor-keys-vitest-migration branch from b18bd2f to 008698e Compare March 16, 2025 13:10

aryaemami59 added 8 commits March 21, 2025 20:19

Merge branch 'main' of https://github.com/typescript-eslint/typescrip…

c806ec9

…t-eslint into chore/visitor-keys-vitest-migration

Merge branch 'main' of https://github.com/typescript-eslint/typescrip…

6600e84

…t-eslint into chore/visitor-keys-vitest-migration

Update vitest to version 3.0.9

e8e1baf

Update @vitest/eslint-plugin to version 1.1.38

bd97ae0

Merge branch 'main' of https://github.com/typescript-eslint/typescrip…

86fa55b

…t-eslint into chore/visitor-keys-vitest-migration

Merge branch 'main' of https://github.com/typescript-eslint/typescrip…

f36c314

…t-eslint into chore/visitor-keys-vitest-migration

Update vitest to version 3.1.1

434d13f

Merge branch 'main' of https://github.com/typescript-eslint/typescrip…

a90d7c3

…t-eslint into chore/visitor-keys-vitest-migration

43081j reviewed Apr 1, 2025

View reviewed changes

packages/visitor-keys/tests/visitor-keys.test.ts Outdated Show resolved Hide resolved

aryaemami59 added 6 commits April 2, 2025 04:45

Merge branch 'main' of https://github.com/typescript-eslint/typescrip…

237a701

…t-eslint into chore/visitor-keys-vitest-migration

Move nonIgnoredKeys out of the describe block

53bf358

Update @vitest/eslint-plugin to version 1.1.39

c81cbab

Fix knip config

a61e8fc

Update vite to version 6.2.5

94b1cd1

Merge branch 'main' of https://github.com/typescript-eslint/typescrip…

734dc65

…t-eslint into chore/visitor-keys-vitest-migration

aryaemami59 commented Apr 7, 2025

View reviewed changes

Merge branch 'main' of https://github.com/typescript-eslint/typescrip…

b497d0c

…t-eslint into chore/visitor-keys-vitest-migration

JoshuaKGoldberg previously approved these changes Apr 7, 2025

View reviewed changes

packages/visitor-keys/tests/visitor-keys.test.ts Show resolved Hide resolved

JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Apr 7, 2025

Merge branch 'main' of https://github.com/typescript-eslint/typescrip…

e7ad033

…t-eslint into chore/visitor-keys-vitest-migration

aryaemami59 dismissed JoshuaKGoldberg’s stale review via e7ad033 April 7, 2025 19:31

JoshuaKGoldberg merged commit d1f57a7 into typescript-eslint:main Apr 10, 2025
57 of 59 checks passed

JoshuaKGoldberg mentioned this pull request Jan 28, 2025

Repo: Move from Jest to Vitest #7112

Closed

14 tasks

github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

chore(visitor-keys): migrate from `jest` to `vitest` #10773

chore(visitor-keys): migrate from `jest` to `vitest` #10773

Uh oh!

aryaemami59 commented Feb 4, 2025

Uh oh!

typescript-eslint bot commented Feb 4, 2025

Uh oh!

netlify bot commented Feb 4, 2025 •

edited

Loading

Uh oh!

nx-cloud bot commented Feb 4, 2025 •

edited

Loading

Uh oh!

codecov bot commented Feb 4, 2025 •

edited

Loading

Uh oh!

JoshuaKGoldberg commented Feb 25, 2025

Uh oh!

Uh oh!

43081j commented Apr 1, 2025

Uh oh!

aryaemami59 Apr 7, 2025

Uh oh!

JoshuaKGoldberg left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

chore(visitor-keys): migrate from jest to vitest #10773

chore(visitor-keys): migrate from jest to vitest #10773

Uh oh!

Conversation

aryaemami59 commented Feb 4, 2025

PR Checklist

Overview

Uh oh!

typescript-eslint bot commented Feb 4, 2025

Uh oh!

netlify bot commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for typescript-eslint ready!

Uh oh!

nx-cloud bot commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JoshuaKGoldberg commented Feb 25, 2025

Uh oh!

Uh oh!

43081j commented Apr 1, 2025

Uh oh!

aryaemami59 Apr 7, 2025

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chore(visitor-keys): migrate from `jest` to `vitest` #10773

chore(visitor-keys): migrate from `jest` to `vitest` #10773

netlify bot commented Feb 4, 2025 •

edited

Loading

nx-cloud bot commented Feb 4, 2025 •

edited

Loading

codecov bot commented Feb 4, 2025 •

edited

Loading