feat(eslint-plugin): Support abstract members in member-ordering rule (#395)#1004
feat(eslint-plugin): Support abstract members in member-ordering rule (#395)#1004JamesHenry merged 8 commits intotypescript-eslint:masterfrom
Conversation
|
Thanks for the PR, @hsmitty93! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #1004 +/- ##
==========================================
+ Coverage 94.06% 94.06% +<.01%
==========================================
Files 115 115
Lines 5086 5089 +3
Branches 1423 1426 +3
==========================================
+ Hits 4784 4787 +3
Misses 174 174
Partials 128 128
|
bradzacher
added
the
enhancement: plugin rule option
|
Will add more Unit tests to increase coverage
|
4 participants
Fixes #395
Member-ordering rule before had no implementation for abstract members and were treating them as private. These changes support abstract members with 'abstract' being used as another scope.
Default order with abstract members is below the scopes 'static' and 'instance'