Skip to content

Repo: Add a CI check that 'breaking change' PR descriptions start with the right title text #9027

New issue
New issue
Closed
#9050
Closed
Repo: Add a CI check that 'breaking change' PR descriptions start with the right title text#9027
#9050
Labels
accepting prsGo ahead, send a pull request that resolves this issuelocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.repo maintenancethings to do with maintenance of the repo, and not with code/docs
@JoshuaKGoldberg

Description

@JoshuaKGoldberg
JoshuaKGoldberg
opened on Apr 29, 2024

Suggestion

Our breaking change PRs don't need ! in their title. In fact, we're not even sure our semantic release notes generator supports ! at all! Let's add a CI check to ensure that no PR titles include !.

Example where I forgot about this: #8934

Related to #5884. That one is about the PR body. This one is about the PR title.

💖

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issuelocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.repo maintenancethings to do with maintenance of the repo, and not with code/docs

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions