Suggestion
This PR #7567 pinned PRIMARY_NODE_VERSION variable in CI to >=20.6.1
|
env: |
|
PRIMARY_NODE_VERSION: '>=20.6.1' |
But this variable is also compared to matrix.node-version which van be 16 or 20
|
# collect coverage on the primary node version |
|
# we don't collect coverage on other node versions so they run faster |
|
# note that we don't do this as a single `run` with a flag because some |
|
# packages don't collect coverage on purpose, so forcing `--coverage=true` |
|
# would override the config |
|
- name: Run unit tests with coverage for ${{ matrix.package }} |
|
if: env.PRIMARY_NODE_VERSION == matrix.node-version |
|
run: npx nx test ${{ matrix.package }} |
|
env: |
|
CI: true |
|
- name: Run unit tests for ${{ matrix.package }} |
|
if: env.PRIMARY_NODE_VERSION != matrix.node-version |
|
run: npx nx test ${{ matrix.package }} --coverage=false |
|
env: |
|
CI: true |
|
|
|
- name: Store coverage for uploading |
|
if: env.PRIMARY_NODE_VERSION == matrix.node-version |
|
uses: actions/upload-artifact@v3 |
|
with: |
|
name: ${{ matrix.package }}-coverage |
|
path: packages/${{ matrix.package }}/coverage/lcov.info |
|
# Sadly 1 day is the minimum |
|
retention-days: 1 |
'>=20.6.1' == '20' -> false
Thus, the coverage isn't collected and uploaded
I think we can unpin it since the current version of Node.js is already 20.10.0
